Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert to stunnel5 #1559

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Conversation

dankova22
Copy link
Contributor

Revert to stunnel5 to fix mount issues

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 7, 2025
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 7, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @dankova22. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 7, 2025
@mskanth972
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 7, 2025
@dankova22 dankova22 force-pushed the stunnel-fix branch 4 times, most recently from 86881cc to 770f9d7 Compare January 7, 2025 18:09
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 7, 2025
@dankova22 dankova22 force-pushed the stunnel-fix branch 3 times, most recently from 23893ca to 534ec88 Compare January 7, 2025 19:05
@dankova22
Copy link
Contributor Author

/test pull-aws-efs-csi-driver-unit

@mskanth972
Copy link
Contributor

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 7, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dankova22, mskanth972

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 7, 2025
@k8s-ci-robot k8s-ci-robot merged commit 26380c9 into kubernetes-sigs:master Jan 7, 2025
6 checks passed
@andrewjamesbrown
Copy link
Contributor

@dankova22 @mskanth972 looks like this reverts my PR, but it re-introduces security vulnerabilities back into efs-csi-driver.

I noticed when implementing that PR that the stunnel5 package was removed, and the regular stunnel package is 5.58-1.amzn2023.0.2 (see the release notes.

Checking the version on a container running v2.1.3 confirms this:

% k get pod/efs-csi-node-v9l2t -o yaml | yq '.spec.containers[0].image'
public.ecr.aws/efs-csi-driver/amazon/aws-efs-csi-driver:v2.1.3

% k exec -ti efs-csi-node-v9l2t -- stunnel --version
Defaulted container "efs-plugin" out of: efs-plugin, csi-driver-registrar, liveness-probe
[ ] Initializing inetd mode configuration
[ ] Clients allowed=32000
[.] stunnel 5.58 on x86_64-amazon-linux-gnu platform
[.] Compiled with OpenSSL 3.0.5 5 Jul 2022
[.] Running  with OpenSSL 3.0.8 7 Feb 2023
[.] Threading:PTHREAD Sockets:POLL,IPv6 TLS:ENGINE,OCSP,PSK,SNI
[ ] errno: (*__errno_location ())
[!] Invalid configuration file name "--version"
[!] realpath: No such file or directory (2)
command terminated with exit code 1

@dankova22
Copy link
Contributor Author

Raised an issue with distro team to add stunnel5 to new distros aws/eks-distro-build-tooling#1591

@andrewjamesbrown
Copy link
Contributor

@dankova22 The release note differences indicate that stunnel in AL23 is the same as stunnel5 in AL2, unless I'm misunderstanding something.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants