Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metadata.namespace to chart templates #1376

Conversation

Kellen275
Copy link
Contributor

This MR aligns with practices followed by the aws-ebs-csi-driver chart.

This also improves compatibility with ArgoCD, which otherwise will complain when it detects no namespace field for namespaced k8s resources. See screenshot below

Screenshot from 2024-06-17 08-37-02

Copy link

linux-foundation-easycla bot commented Jun 17, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jun 17, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @Kellen275!

It looks like this is your first PR to kubernetes-sigs/aws-efs-csi-driver 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/aws-efs-csi-driver has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 17, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @Kellen275. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 17, 2024
@Kellen275
Copy link
Contributor Author

Kellen275 commented Jun 17, 2024

Not quite sure why the EasyCLA is marked as "Not Covered" still. Received a confirmation email and all looks good?

Screenshot from 2024-06-17 08-43-11

@dims
Copy link
Member

dims commented Jun 17, 2024

/easycla

@dims
Copy link
Member

dims commented Jun 17, 2024

@Kellen275 the commits show From: Kellen Sappington <[email protected]> as your email, if you match that with the email id you used for CLA that would make it work. You can also try associating this email with your github as an additional email as an alternative.

PS: https://github.com/kubernetes-sigs/aws-efs-csi-driver/commit/fa33fad37ffd42b009b3e33a3e0bb4c9a2c9b357.patch

@Kellen275 Kellen275 force-pushed the kgsappington/template-namespaces branch from 794503f to 5e1f78a Compare June 17, 2024 12:59
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jun 17, 2024
@Kellen275
Copy link
Contributor Author

Thanks @dims , looks like that was it 🙂

@Kellen275 Kellen275 changed the title Add metadata.namespace to chart templates Add metadata.namespace to chart templates Jun 20, 2024
@Kellen275
Copy link
Contributor Author

Hello @dims , is there anything remaining for this PR?

@dims
Copy link
Member

dims commented Sep 21, 2024

/ok-to-test

/assign @mskanth972 @arnavgup1

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Sep 21, 2024
@k8s-ci-robot
Copy link
Contributor

@dims: GitHub didn't allow me to assign the following users: arnavgup1.

Note that only kubernetes-sigs members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/ok-to-test

/assign @mskanth972 @arnavgup1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 21, 2024
@Kellen275
Copy link
Contributor Author

@mskanth972 any update?

@mskanth972
Copy link
Contributor

Can you squash the commits so that I can help in merge?

@Kellen275 Kellen275 force-pushed the kgsappington/template-namespaces branch 2 times, most recently from fce0fa7 to 0e6ca1d Compare November 19, 2024 22:24
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 26, 2024
@Kellen275 Kellen275 force-pushed the kgsappington/template-namespaces branch from 0e6ca1d to 1852b04 Compare November 27, 2024 13:17
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 27, 2024
@Kellen275
Copy link
Contributor Author

@mskanth972 Commits should be squashed, thank you for helping out!

@mskanth972
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 2, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Kellen275, mskanth972

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 2, 2024
@k8s-ci-robot k8s-ci-robot merged commit f49f9f2 into kubernetes-sigs:master Dec 2, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants