-
Notifications
You must be signed in to change notification settings - Fork 561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add metadata.namespace
to chart templates
#1376
Add metadata.namespace
to chart templates
#1376
Conversation
|
Welcome @Kellen275! |
Hi @Kellen275. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/easycla |
@Kellen275 the commits show |
794503f
to
5e1f78a
Compare
Thanks @dims , looks like that was it 🙂 |
metadata.namespace
to chart templates
Hello @dims , is there anything remaining for this PR? |
/ok-to-test /assign @mskanth972 @arnavgup1 |
@dims: GitHub didn't allow me to assign the following users: arnavgup1. Note that only kubernetes-sigs members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@mskanth972 any update? |
Can you squash the commits so that I can help in merge? |
fce0fa7
to
0e6ca1d
Compare
0e6ca1d
to
1852b04
Compare
@mskanth972 Commits should be squashed, thank you for helping out! |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Kellen275, mskanth972 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This MR aligns with practices followed by the aws-ebs-csi-driver chart.
This also improves compatibility with ArgoCD, which otherwise will complain when it detects no namespace field for namespaced k8s resources. See screenshot below