feat(backend): Add support for job and task placeholders in the KFP backend #11599
+153
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @HumairAK |
mprahl
force-pushed
the
placeholders
branch
2 times, most recently
from
0455182 to
dec765a
Compare
This adds support for the following placeholders in the KFP backend: - dsl.PIPELINE_JOB_NAME_PLACEHOLDER - dsl.PIPELINE_JOB_RESOURCE_NAME_PLACEHOLDER - dsl.PIPELINE_JOB_ID_PLACEHOLDER - dsl.PIPELINE_TASK_NAME_PLACEHOLDER - dsl.PIPELINE_TASK_ID_PLACEHOLDER Resolves: kubeflow#10453 Signed-off-by: mprahl <[email protected]>
|
tested and verified, code lgtm Thank you! highly sought after feature /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: HumairAK The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Thank you @mprahl |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes:
This adds support for the following placeholders in the KFP backend.
Resolves:
#10453
Checklist: