Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chor(test) : Fix kfp-sdk-test for different python versions #11559

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

chahatsagarmain
Copy link

Description of your changes:
Resolve #11558

Checklist:

Signed-off-by: chahatsagarmain <[email protected]>
Copy link

Hi @chahatsagarmain. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@chahatsagarmain
Copy link
Author

@hbelmiro can you run the test once ?

@hbelmiro
Copy link
Contributor

/ok-to-test

Copy link

Approvals successfully granted for pending runs.

Signed-off-by: chahatsagarmain <[email protected]>
Signed-off-by: chahatsagarmain <[email protected]>
Signed-off-by: chahatsagarmain <[email protected]>
@google-oss-prow google-oss-prow bot added size/S and removed size/M labels Jan 28, 2025
Signed-off-by: chahatsagarmain <[email protected]>
@hbelmiro
Copy link
Contributor

/ok-to-test

Copy link

Approvals successfully granted for pending runs.

@chahatsagarmain
Copy link
Author

@hbelmiro still working on this , I was running tests on my fork .

Signed-off-by: chahatsagarmain <[email protected]>
@google-oss-prow google-oss-prow bot added size/M and removed size/S labels Jan 28, 2025
@chahatsagarmain chahatsagarmain marked this pull request as ready for review January 28, 2025 21:21
@google-oss-prow google-oss-prow bot requested a review from DharmitD January 28, 2025 21:21
@hbelmiro
Copy link
Contributor

/ok-to-test

Copy link

Approvals successfully granted for pending runs.

Copy link
Contributor

@hbelmiro hbelmiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

cc @HumairAK

Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: hbelmiro
Once this PR has been reviewed and has the lgtm label, please assign chensun for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore(<test>): kfp-sdk-tests has an error in the python version variable
2 participants