-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chor(test) : Fix kfp-sdk-test for different python versions #11559
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: chahatsagarmain <[email protected]>
Hi @chahatsagarmain. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@hbelmiro can you run the test once ? |
/ok-to-test |
Approvals successfully granted for pending runs. |
Signed-off-by: chahatsagarmain <[email protected]>
Signed-off-by: chahatsagarmain <[email protected]>
Signed-off-by: chahatsagarmain <[email protected]>
Signed-off-by: chahatsagarmain <[email protected]>
/ok-to-test |
Approvals successfully granted for pending runs. |
@hbelmiro still working on this , I was running tests on my fork . |
Signed-off-by: chahatsagarmain <[email protected]>
/ok-to-test |
Approvals successfully granted for pending runs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
cc @HumairAK
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: hbelmiro The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description of your changes:
Resolve #11558
Checklist: