Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(test): Fixed namespace in tests #11545

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

hbelmiro
Copy link
Contributor

@hbelmiro hbelmiro commented Jan 21, 2025

This PR replaces the ${NAMESPACE} variable with kubeflow.
For some reason, some tests were being skipped and started to run when I added the namespace. That required me to forward ports and change one test.

Checklist:

Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@hbelmiro hbelmiro changed the title chore(test): Fixed namespace in tests WIP - chore(test): Fixed namespace in tests Jan 21, 2025
@hbelmiro hbelmiro changed the title WIP - chore(test): Fixed namespace in tests chore(test): Fixed namespace in tests Jan 21, 2025
@hbelmiro hbelmiro marked this pull request as ready for review January 21, 2025 16:38
@google-oss-prow google-oss-prow bot requested a review from HumairAK January 21, 2025 16:38
@hbelmiro
Copy link
Contributor Author

@HumairAK @chensun can one of you guys PTAL?

@HumairAK
Copy link
Collaborator

/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HumairAK

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

@DharmitD DharmitD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Jan 27, 2025
@google-oss-prow google-oss-prow bot merged commit 37a7b4e into kubeflow:master Jan 27, 2025
32 checks passed
@hbelmiro hbelmiro deleted the fix-namespace branch January 27, 2025 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants