-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(test): Fixed namespace in tests #11545
Conversation
Skipping CI for Draft Pull Request. |
Signed-off-by: Helber Belmiro <[email protected]>
4f27015
to
c4b0fc7
Compare
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: HumairAK The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
This PR replaces the
${NAMESPACE}
variable withkubeflow
.For some reason, some tests were being skipped and started to run when I added the namespace. That required me to forward ports and change one test.
Checklist: