chore(tests): added makefiles for testing workflow tests locally #11509
Conversation
Signed-off-by: chahatsagarmain <[email protected]>
|
Hi @chahatsagarmain. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/ok-to-test |
|
@anishasthana you may like to review this. |
|
Could you document how to launch the tests in https://github.com/kubeflow/pipelines/blob/master/test/README.md ? |
|
@chahatsagarmain I added one more item to the issue's acceptance criteria.
|
Signed-off-by: chahatsagarmain <[email protected]>
|
New changes are detected. LGTM label has been removed. |
|
hello @chahatsagarmain , following up with our chat on slack, would you please make sure that this command ( related commit in parallel pr: it should point to the thanks for your collaboration in advance. cc: @hbelmiro |
There was a problem hiding this comment.
Please add the missing .github/workflows/presubmit-backend.yml to on.pull_request.paths.
| @@ -53,4 +53,4 @@ jobs: | |||
| run: pip install -r ./test/sdk-execution-tests/requirements.txt | |||
|
|
|||
| - name: Run component YAML tests | |||
| run: ./test/presubmit-component-yaml.sh | |||
| run: make sdk-component-yaml | |||
There was a problem hiding this comment.
You missed the setup for this one.
| export KFP_ENDPOINT="http://localhost:8888" | ||
| export TIMEOUT_SECONDS=2700 | ||
| pytest ./test/sdk-execution-tests/sdk_execution_tests.py --asyncio-task-timeout $TIMEOUT_SECONDS | ||
| make sdk-execution |
There was a problem hiding this comment.
You missed the setup for this one.
| @@ -33,4 +33,4 @@ jobs: | |||
| run: pip install yapf | |||
|
|
|||
| - name: Run YAPF SDK Tests | |||
| run: ./test/presubmit-yapf-sdk.sh | |||
| run: make sdk-yapf | |||
There was a problem hiding this comment.
You missed the setup for this one.
Makefile
Outdated
There was a problem hiding this comment.
Please rename them to have test- in the beginning of their names so it will be easier for contributors to find them.
For example, backend-test-flip-coin -> test-backend-flip-coin.
|
/ok-to-test |
|
Approvals successfully granted for pending runs. |
@mahdikhashan as per #11512 (comment), you need to add the new target in your PR, otherwise it won't pass the CI and can't get merged. |
Signed-off-by: chahatsagarmain <[email protected]>
Signed-off-by: chahatsagarmain <[email protected]>
|
/ok-to-test |
|
Approvals successfully granted for pending runs. |
Signed-off-by: chahatsagarmain <[email protected]>
|
/ok-to-test |
|
Approvals successfully granted for pending runs. |
Description of your changes:
Issue #11494
Added makefiles for tests and setup each test locally .
Checklist: