-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: no overwrite when run launcher as worker #628
Conversation
Signed-off-by: kuizhiqing <[email protected]>
8a112ed
to
c7b032c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implementation is lgtm
Could you extend unit tests here?:
func TestNewLauncherAndWorker(t *testing.T) { |
Signed-off-by: kuizhiqing <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
/lgtm
/assign @alculquicondor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alculquicondor The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Default implementation overwrite envs
NVIDIA_VISIBLE_DEVICES
andNVIDIA_DRIVER_CAPABILITIES
which is not work in theRunLauncherAsWorker
case with GPU.