more Deref

Signed-off-by: kuizhiqing <[email protected]>
kubeflow · Feb 21, 2024 · 934ee87 · 934ee87
1 parent 224e5e2
commit 934ee87
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/pkg/controller/mpi_job_controller.go b/pkg/controller/mpi_job_controller.go
@@ -1289,7 +1289,7 @@ func newConfigMap(mpiJob *kubeflow.MPIJob, workerReplicas int32) *corev1.ConfigM
 	// note that pod.spec.dnsConfig also affect the svc resolution
 	// ref: https://kubernetes.io/docs/concepts/services-networking/dns-pod-service/
 	// launcher can be reach with hostname or service name
-	if mpiJob.Spec.RunLauncherAsWorker != nil && *mpiJob.Spec.RunLauncherAsWorker {
+	if ptr.Deref(mpiJob.Spec.RunLauncherAsWorker, false) {
 		launcherService := mpiJob.Name + launcherSuffix
 		switch mpiJob.Spec.MPIImplementation {
 		case kubeflow.MPIImplementationOpenMPI: