Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove patching of istio; update values for seccompvalue via chart #2938

Open
wants to merge 7 commits into
base: istio-cni-by-default-with-seccomp-value
Choose a base branch
from
Open

Remove patching of istio; update values for seccompvalue via chart #2938

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b251c71
istio-cni by default
juliusvonkohout Nov 4, 2024
10d1336
istio-cni installation script by default
juliusvonkohout Nov 4, 2024
e57c0c4
Disable init container injection for ray
fraenkel Dec 11, 2024
da3dc97
Remove patching of istio; update values for seccompvalue via chart
MaxKavun Dec 20, 2024
1b84a65
remove github step
MaxKavun Dec 20, 2024
02458b0
Update istio cni to 1.24.2 version
MaxKavun Dec 23, 2024
058f0e7
Update istio to 1.24.2
MaxKavun Dec 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/admission_webhook_test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
name: Build & Apply PodDefaults manifests in KinD
on:

Check warning on line 2 in .github/workflows/admission_webhook_test.yaml

View workflow job for this annotation

GitHub Actions / format_YAML_files 

2:1 [truthy] truthy value should be one of [false, true]
pull_request:
paths:
- tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh
- .github/workflows/admission_webhook_test.yaml
- apps/admission-webhook/upstream/**
- tests/gh-actions/install_istio.sh
- tests/gh-actions/install_istio-cni.sh
- tests/gh-actions/install_cert_manager.sh
- common/cert-manager/**

Expand All @@ -20,7 +20,7 @@
run: ./tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh

- name: Install Istio
run: ./tests/gh-actions/install_istio.sh
run: ./tests/gh-actions/install_istio-cni.sh

- name: Install cert-manager
run: ./tests/gh-actions/install_cert_manager.sh
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/centraldashboard_test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
name: Build & Apply CentralDashboard manifests in KinD
on:

Check warning on line 2 in .github/workflows/centraldashboard_test.yaml

View workflow job for this annotation

GitHub Actions / format_YAML_files 

2:1 [truthy] truthy value should be one of [false, true]
pull_request:
paths:
- tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh
- .github/workflows/centraldashboard_test.yaml
- apps/centraldashboard/upstream/**
- tests/gh-actions/install_istio.sh
- tests/gh-actions/install_istio-cni.sh

jobs:
build:
Expand All @@ -18,7 +18,7 @@
run: ./tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh

- name: Install Istio
run: ./tests/gh-actions/install_istio.sh
run: ./tests/gh-actions/install_istio-cni.sh

- name: Build & Apply manifests
run: |
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/dex_test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
name: Build & Apply Dex manifests in KinD
on:

Check warning on line 2 in .github/workflows/dex_test.yaml

View workflow job for this annotation

GitHub Actions / format_YAML_files 

2:1 [truthy] truthy value should be one of [false, true]
pull_request:
paths:
- tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh
- .github/workflows/dex_test.yaml
- common/dex/base/**
- tests/gh-actions/install_istio.sh
- tests/gh-actions/install_istio-cni.sh

jobs:
build:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/jupyter_web_application_test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
name: Build & Apply JWA manifests in KinD
on:

Check warning on line 2 in .github/workflows/jupyter_web_application_test.yaml

View workflow job for this annotation

GitHub Actions / format_YAML_files 

2:1 [truthy] truthy value should be one of [false, true]
pull_request:
paths:
- tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh
- .github/workflows/jupyter_web_application_test.yaml
- apps/jupyter/jupyter-web-app/upstream/**
- tests/gh-actions/install_istio.sh
- tests/gh-actions/install_istio-cni.sh

jobs:
build:
Expand All @@ -18,7 +18,7 @@
run: ./tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh

- name: Install Istio
run: ./tests/gh-actions/install_istio.sh
run: ./tests/gh-actions/install_istio-cni.sh

- name: Build & Apply manifests
run: |
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/katib_test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
name: Build & Apply Katib manifests in KinD
on:

Check warning on line 2 in .github/workflows/katib_test.yaml

View workflow job for this annotation

GitHub Actions / format_YAML_files 

2:1 [truthy] truthy value should be one of [false, true]
pull_request:
paths:
- tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh
- .github/workflows/katib_test.yaml
- apps/katib/upstream/**
- tests/gh-actions/install_istio.sh
- tests/gh-actions/install_istio-cni.sh
- tests/gh-actions/install_cert_manager.sh
- common/cert-manager/**

Expand All @@ -20,7 +20,7 @@
run: ./tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh

- name: Install Istio
run: ./tests/gh-actions/install_istio.sh
run: ./tests/gh-actions/install_istio-cni.sh

- name: Install cert-manager
run: ./tests/gh-actions/install_cert_manager.sh
Expand Down
62 changes: 0 additions & 62 deletions .github/workflows/kserve_cni_test.yaml
View file
Open in desktop

This file was deleted.

4 changes: 2 additions & 2 deletions .github/workflows/kserve_m2m_test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: Deploy and test KServe with m2m auth in KinD
on:

Check warning on line 2 in .github/workflows/kserve_m2m_test.yaml

View workflow job for this annotation

GitHub Actions / format_YAML_files 

2:1 [truthy] truthy value should be one of [false, true]
pull_request:
paths:
- tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh
Expand All @@ -7,7 +7,7 @@
- contrib/kserve/**
- common/oauth2-proxy/**
- common/istio*/**
- tests/gh-actions/install_istio.sh
- tests/gh-actions/install_istio-cni.sh
- tests/gh-actions/install_oauth2-proxy.sh
- tests/gh-actions/install_cert_manager.sh
- common/cert-manager/**
Expand All @@ -32,7 +32,7 @@
run: kustomize build common/kubeflow-namespace/base | kubectl apply -f -

- name: Install Istio
run: ./tests/gh-actions/install_istio.sh
run: ./tests/gh-actions/install_istio-cni.sh

- name: Install oauth2-proxy
run: ./tests/gh-actions/install_oauth2-proxy.sh
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/kserve_test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: Build & Apply KServe manifests in KinD
on:

Check warning on line 2 in .github/workflows/kserve_test.yaml

View workflow job for this annotation

GitHub Actions / format_YAML_files 

2:1 [truthy] truthy value should be one of [false, true]
pull_request:
paths:
- tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh
Expand All @@ -25,7 +25,7 @@
run: kustomize build common/kubeflow-namespace/base | kubectl apply -f -

- name: Install Istio
run: ./tests/gh-actions/install_istio.sh
run: ./tests/gh-actions/install_istio-cni.sh

- name: Install cert-manager
run: ./tests/gh-actions/install_cert_manager.sh
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/model_registry_test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
# If anyone changes or improve the following tests for Model Registry, please
# consider reflecting the same changes on https://github.com/kubeflow/model-registry
name: Deploy and test Kubeflow Model Registry
on:

Check warning on line 4 in .github/workflows/model_registry_test.yaml

View workflow job for this annotation

GitHub Actions / format_YAML_files 

4:1 [truthy] truthy value should be one of [false, true]
pull_request:
paths:
- tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh
- apps/model-registry/upstream/**
- tests/gh-actions/install_istio.sh
- tests/gh-actions/install_istio-cni.sh
- common/istio*/**

jobs:
Expand All @@ -26,7 +26,7 @@
run: kustomize build common/kubeflow-namespace/base | kubectl apply -f -

- name: Install Istio
run: ./tests/gh-actions/install_istio.sh
run: ./tests/gh-actions/install_istio-cni.sh

- name: Install oauth2-proxy
run: ./tests/gh-actions/install_oauth2-proxy.sh
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/notebook_controller_m2m_test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: Test Notebook Controller with m2m auth manifests in KinD
on:

Check warning on line 2 in .github/workflows/notebook_controller_m2m_test.yaml

View workflow job for this annotation

GitHub Actions / format_YAML_files 

2:1 [truthy] truthy value should be one of [false, true]
pull_request:
paths:
- tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh
Expand All @@ -7,7 +7,7 @@
- apps/jupyter/**
- common/oauth2-proxy/**
- common/istio*/**
- tests/gh-actions/install_istio.sh
- tests/gh-actions/install_istio-cni.sh
- tests/gh-actions/install_oauth2-proxy.sh
- tests/gh-actions/install_multi_tenancy.sh

Expand All @@ -28,13 +28,13 @@
run: kustomize build common/kubeflow-namespace/base | kubectl apply -f -

- name: Install Istio
run: ./tests/gh-actions/install_istio.sh
run: ./tests/gh-actions/install_istio-cni.sh

- name: Install oauth2-proxy
run: ./tests/gh-actions/install_oauth2-proxy.sh

- name: Install kubeflow-istio-resources
run: kustomize build common/istio-1-23/kubeflow-istio-resources/base | kubectl apply -f -
run: kustomize build common/istio-cni-1-23/kubeflow-istio-resources/base | kubectl apply -f -

- name: Install KF Multi Tenancy
run: ./tests/gh-actions/install_multi_tenancy.sh
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/notebook_controller_test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
name: Build & Apply Notebook Controller manifests in KinD
on:

Check warning on line 2 in .github/workflows/notebook_controller_test.yaml

View workflow job for this annotation

GitHub Actions / format_YAML_files 

2:1 [truthy] truthy value should be one of [false, true]
pull_request:
paths:
- tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh
- .github/workflows/notebook_controller_test.yaml
- apps/jupyter/notebook-controller/upstream/**
- tests/gh-actions/install_istio.sh
- tests/gh-actions/install_istio-cni.sh
- common/istio*/**

jobs:
Expand All @@ -19,7 +19,7 @@
run: ./tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh

- name: Install Istio
run: ./tests/gh-actions/install_istio.sh
run: ./tests/gh-actions/install_istio-cni.sh

- name: Build & Apply manifests
run: |
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/pipeline_run_from_notebook.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ on:
- .github/workflows/pipeline_run_from_notebook.yaml
- apps/jupyter/notebook-controller/upstream/**
- apps/pipeline/upstream/**
- tests/gh-actions/install_istio.sh
- tests/gh-actions/install_istio-cni.sh
- tests/gh-actions/install_cert_manager.sh
- common/cert-manager/**
- common/oauth2-proxy/**
Expand All @@ -25,7 +25,7 @@ jobs:
run: ./tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh

- name: Install Istio
run: ./tests/gh-actions/install_istio.sh
run: ./tests/gh-actions/install_istio-cni.sh

- name: Install oauth2-proxy
run: ./tests/gh-actions/install_oauth2-proxy.sh
Expand All @@ -37,7 +37,7 @@ jobs:
run: kustomize build common/kubeflow-namespace/base | kubectl apply -f -

- name: Install kubeflow-istio-resources
run: kustomize build common/istio-1-23/kubeflow-istio-resources/base | kubectl apply -f -
run: kustomize build common/istio-cni-1-23/kubeflow-istio-resources/base | kubectl apply -f -

- name: Install KF Pipelines
run: ./tests/gh-actions/install_pipelines.sh
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/pipeline_swfs_test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ on:
- tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh
- .github/workflows/pipeline_swfs_test.yaml
- apps/pipeline/upstream/**
- tests/gh-actions/install_istio.sh
- tests/gh-actions/install_istio-cni.sh
- tests/gh-actions/install_cert_manager.sh
- tests/gh-actions/install_oauth2-proxy.sh
- common/cert-manager/**
Expand All @@ -27,7 +27,7 @@ jobs:
run: ./tests/gh-actions/install_kubectl.sh

- name: Install Istio
run: ./tests/gh-actions/install_istio.sh
run: ./tests/gh-actions/install_istio-cni.sh

- name: Install oauth2-proxy
run: ./tests/gh-actions/install_oauth2-proxy.sh
Expand All @@ -45,7 +45,7 @@ jobs:
run: ./tests/gh-actions/install_multi_tenancy.sh

- name: Install kubeflow-istio-resources
run: kustomize build common/istio-1-23/kubeflow-istio-resources/base | kubectl apply -f -
run: kustomize build common/istio-cni-1-23/kubeflow-istio-resources/base | kubectl apply -f -

- name: Create KF Profile
run: kustomize build common/user-namespace/base | kubectl apply -f -
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/pipeline_test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ on:
- tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh
- .github/workflows/pipeline_test.yaml
- apps/pipeline/upstream/**
- tests/gh-actions/install_istio.sh
- tests/gh-actions/install_istio-cni.sh
- tests/gh-actions/install_cert_manager.sh
- tests/gh-actions/install_oauth2-proxy.sh
- common/cert-manager/**
Expand All @@ -26,7 +26,7 @@ jobs:
run: ./tests/gh-actions/install_kubectl.sh

- name: Install Istio
run: ./tests/gh-actions/install_istio.sh
run: ./tests/gh-actions/install_istio-cni.sh

- name: Install oauth2-proxy
run: ./tests/gh-actions/install_oauth2-proxy.sh
Expand All @@ -44,7 +44,7 @@ jobs:
run: ./tests/gh-actions/install_multi_tenancy.sh

- name: Install kubeflow-istio-resources
run: kustomize build common/istio-1-23/kubeflow-istio-resources/base | kubectl apply -f -
run: kustomize build common/istio-cni-1-23/kubeflow-istio-resources/base | kubectl apply -f -

- name: Create KF Profile
run: kustomize build common/user-namespace/base | kubectl apply -f -
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/profiles_test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ on:
- tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh
- .github/workflows/profiles_test.yaml
- apps/profiles/upstream/**
- tests/gh-actions/install_istio.sh
- tests/gh-actions/install_istio-cni.sh
- common/istio*/**

jobs:
Expand All @@ -19,7 +19,7 @@ jobs:
run: ./tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh

- name: Install Istio
run: ./tests/gh-actions/install_istio.sh
run: ./tests/gh-actions/install_istio-cni.sh

- name: Build & Apply manifests
run: |
Expand Down
10 changes: 0 additions & 10 deletions .github/workflows/pss_test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,16 +33,6 @@ jobs:
- name: Install Istio CNI
run: ./tests/gh-actions/install_istio-cni.sh

- name: Configure istio init container with seccompProfile attribute
run: |
kubectl get cm istio-sidecar-injector -n istio-system -o yaml > temporary_patch.yaml
sed -i '0,/runAsNonRoot: true/{s//&\n seccompProfile:\n type: RuntimeDefault/}' temporary_patch.yaml
sed -i '/runAsNonRoot: true/{N; /runAsUser: {{ .ProxyUID | default "1337" }}/a\
seccompProfile:\n type: RuntimeDefault
}' temporary_patch.yaml
kubectl apply -f temporary_patch.yaml
rm temporary_patch.yaml

- name: Install oauth2-proxy
run: ./tests/gh-actions/install_oauth2-proxy.sh

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ray_test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
run: ./tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh

- name: Install Istio
run: ./tests/gh-actions/install_istio.sh
run: ./tests/gh-actions/install_istio-cni.sh

- name: Install oauth2-proxy
run: ./tests/gh-actions/install_oauth2-proxy.sh
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/spark_test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
run: ./tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh

- name: Install Istio
run: ./tests/gh-actions/install_istio.sh
run: ./tests/gh-actions/install_istio-cni.sh

- name: Install oauth2-proxy
run: ./tests/gh-actions/install_oauth2-proxy.sh
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/tensorboard_controller_test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ on:
- tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh
- .github/workflows/tensorboard_controller_test.yaml
- apps/tensorboard/tensorboard-controller/upstream/**
- tests/gh-actions/install_istio.sh
- tests/gh-actions/install_istio-cni.sh
- common/istio*/**

jobs:
Expand All @@ -19,7 +19,7 @@ jobs:
run: ./tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh

- name: Install Istio
run: ./tests/gh-actions/install_istio.sh
run: ./tests/gh-actions/install_istio-cni.sh

- name: Build & Apply manifests
run: |
Expand Down
Loading
Loading