Synchronize knative manifests v1.16.0

[juliusvonkohout]

@tarekabouzeid lets see what my tests say :-D

[juliusvonkohout]

I get Error from server (InternalError): error when creating "STDIN": Internal error occurred: failed calling webhook "webhook.serving.knative.dev": failed to call webhook: Post "[https://webhook.knative-serving.svc:443/?timeout=10s](https://webhook.knative-serving.svc/?timeout=10s)": dial tcp 10.96.226.205:443: connect: connection refused in Build & Apply KServe manifests in KinD / build (pull_request). I could imagine that the pod is not ready or we might have to apply the manifests twice. Can you try the failing tests locally?

I also see resource mapping not found for name: "queue-proxy" namespace: "knative-serving" from "STDIN": no matches for kind "Image" in version "caching.internal.knative.dev/v1alpha1" ensure CRDs are installed first resource mapping not found for name: "routing-serving-certs" namespace: "knative-serving" from "STDIN": no matches for kind "Certificate" in version "networking.internal.knative.dev/v1alpha1" ensure CRDs are installed first

So we should modify https://github.com/kubeflow/manifests/blob/master/tests/gh-actions/install_knative.sh to first extract and install the CRDs only. Then try a full installation, that might fail due to podss coming up, wait 30 seconds and try again.

#!/bin/bash
set -euo pipefail
echo "Installing KNative CRDs ..."
TODO      - yq 'select(.kind == "CustomResourceDefinition")' manifests.yaml | kubectl apply -f

echo "Installing KNative ..."
set +e
kustomize build common/knative/knative-serving/base | kubectl apply -f -
set -e
kustomize build common/knative/knative-serving/base | kubectl apply -f -

But maybe it is just easier to have a for loop with 3 iterations and a 30 second sleep in between.

[juliusvonkohout]

Ok we need to install and use a YAML formatter in the synchronize manifests script or add knative upstream to the exceptions in the yamllint workflow.

Also GitHub is having issues again with pulling the jupyterlab image I guess ...

[juliusvonkohout]

If it fails again due to github image pull slowness here is proof that it works and we should merge anyway https://github.com/kubeflow/manifests/actions/runs/11916076734

[juliusvonkohout]

/approve

[google-oss-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juliusvonkohout

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [juliusvonkohout]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[tarekabouzeid]

great work @juliusvonkohout !

[tarekabouzeid]

/lgtm