-
Notifications
You must be signed in to change notification settings - Fork 895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Synchronize kubeflow model registry manifests v0.2.5 alpha #2880
Synchronize kubeflow model registry manifests v0.2.5 alpha #2880
Conversation
Signed-off-by: juliusvonkohout <[email protected]>
Signed-off-by: juliusvonkohout <[email protected]>
as mentioned in slack, I confirm no structure change for MR Manifest. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you @juliusvonkohout
I also would suggest renaming PR title
@@ -58,7 +58,7 @@ This repo periodically syncs all official Kubeflow components from their respect | |||
| KServe Models Web App | contrib/kserve/models-web-app | [0.13.0](https://github.com/kserve/models-web-app/tree/0.13.0/config) | | |||
| Kubeflow Pipelines | apps/pipeline/upstream | [2.3.0](https://github.com/kubeflow/pipelines/tree/2.3.0/manifests/kustomize) | | |||
| Kubeflow Tekton Pipelines | apps/kfp-tekton/upstream | [2.0.5](https://github.com/kubeflow/kfp-tekton/tree/2.0.5/manifests/kustomize) | | |||
| Kubeflow Model Registry | apps/model-registry/upstream | [v0.2.1-alpha](https://github.com/kubeflow/model-registry/tree/v0.2.1-alpha/manifests/kustomize) | | |||
| Kubeflow Model Registry | apps/model-registry/upstream | [v0.2.5-alpha](https://github.com/kubeflow/model-registry/tree/v0.2.5-alpha/manifests/kustomize) | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| Kubeflow Model Registry | apps/model-registry/upstream | [v0.2.5-alpha](https://github.com/kubeflow/model-registry/tree/v0.2.5-alpha/manifests/kustomize) | | |
| Kubeflow Model Registry | apps/model-registry/upstream | [v0.2.6-alpha](https://github.com/kubeflow/model-registry/tree/v0.2.5-alpha/manifests/kustomize) | |
@@ -15,7 +15,7 @@ | |||
set -euxo pipefail | |||
IFS=$'\n\t' | |||
|
|||
COMMIT="v0.2.1-alpha" # You can use tags as well | |||
COMMIT="v0.2.5-alpha" # You can use tags as well |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
COMMIT="v0.2.5-alpha" # You can use tags as well | |
COMMIT="v0.2.6-alpha" # You can use tags as well |
Do you want me to synchronize another tag? |
I've never said I didn't like this one, I proposed while it was open to simply update with the just fresh tag. /lgtm We can do another update in a follow-up PR if that is preferred 👍 Thank you |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: juliusvonkohout, tarilabs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@lampajr @rimolive Did you change the manifest structure? because i do not see any real changes.