Skip to content

Commit

Permalink
update the kserve tests
Browse files Browse the repository at this point in the history
Signed-off-by: juliusvonkohout <[email protected]>
  • Loading branch information
juliusvonkohout committed Dec 18, 2024
1 parent 8df1c2f commit 357e518
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 7 deletions.
16 changes: 11 additions & 5 deletions .github/workflows/kserve_m2m_test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -43,11 +43,17 @@ jobs:
- name: Install knative
run: ./tests/gh-actions/install_knative.sh

- name: Build & Apply manifests
- name: Install KServe
run: ./tests/gh-actions/install_kserve.sh

- name: Create test namespace
run: kubectl create ns kserve-test
- name: Install KF Multi Tenancy
run: ./tests/gh-actions/install_multi_tenancy.sh

- name: Install kubeflow-istio-resources
run: kustomize build common/istio-1-23/kubeflow-istio-resources/base | kubectl apply -f -

- name: Create KF Profile
run: kustomize build common/user-namespace/base | kubectl apply -f -

- name: Setup python 3.9
uses: actions/setup-python@v4
Expand All @@ -63,10 +69,10 @@ jobs:
nohup kubectl port-forward --namespace istio-system svc/${INGRESS_GATEWAY_SERVICE} 8080:80 &
while ! curl localhost:8080; do echo waiting for port-forwarding; sleep 1; done; echo port-forwarding ready
- name: Run kserve tests with m2m token from SA default/default
- name: Run kserve tests with m2m token from SA kubeflow-user-example-com/default-editor
run: |
export KSERVE_INGRESS_HOST_PORT=localhost:8080
export KSERVE_M2M_TOKEN="$(kubectl -n default create token default)"
export KSERVE_M2M_TOKEN="$(kubectl -n kubeflow-user-example-com create token default-editor)"
cd ./contrib/kserve/tests && pytest . -vs --log-level info
- name: Run and fail kserve tests without kserve m2m token
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/kserve_test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ jobs:
run: ./tests/gh-actions/install_kserve.sh

- name: Create test namespace
run: kubectl create ns kserve-test
run: kubectl create ns kubeflow-user-example-com # warning, this is not a real KF profile

Check warning on line 40 in .github/workflows/kserve_test.yaml

View workflow job for this annotation

GitHub Actions / format_YAML_files

40:56 [comments] too few spaces before comment

- name: Setup python 3.9
uses: actions/setup-python@v4
Expand Down
2 changes: 1 addition & 1 deletion contrib/kserve/tests/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
logging.basicConfig(level=logging.INFO)

KSERVE_NAMESPACE = "kserve"
KSERVE_TEST_NAMESPACE = "kserve-test"
KSERVE_TEST_NAMESPACE = "kubeflow-user-example-com"
MODEL_CLASS_NAME = "modelClass"


Expand Down

0 comments on commit 357e518

Please sign in to comment.