Adding tests for dex plus restructuring and formatting (#2815)

* fix redirectURIs for in dex config since kubeflow uses oauth2 Signed-off-by: Tom Zaspel <[email protected]> * remove authservice and refactore code Signed-off-by: Tom Zaspel <[email protected]> * remove authservice from github actions and refactore code Signed-off-by: Tom Zaspel <[email protected]> * adjust name of oauth2 in FAQ Signed-off-by: Tom Zaspel <[email protected]> * create new directory in central dashboard called manuel-patches for oauth2-proxy Signed-off-by: Tom Zaspel <[email protected]> * change manuel-patches to overlay Signed-off-by: Tom Zaspel <[email protected]> * Test if user can login to dex Signed-off-by: Tom Zaspel <[email protected]> * Add kubeflow authentication oidc-authservice README.md Signed-off-by: Tom Zaspel <[email protected]> * Fix yaml linter error Signed-off-by: Tom Zaspel <[email protected]> * Fix yaml linting Signed-off-by: Tom Zaspel <[email protected]> * Add changes from comit: 08f217c Signed-off-by: Tom Zaspel <[email protected]> * Fix even more lint issues Signed-off-by: Tom Zaspel <[email protected]> --------- Signed-off-by: Tom Zaspel <[email protected]> Signed-off-by: Tom Zaspel <[email protected]> Co-authored-by: Hansini Karunarathne <[email protected]>
kubeflow · Aug 1, 2024 · 1c464be · 1c464be
1 parent 08f217c
commit 1c464be
Show file tree

Hide file tree

Showing 94 changed files with 833 additions and 954 deletions.
diff --git a/.github/workflows/admission_webhook_test.yaml b/.github/workflows/admission_webhook_test.yaml
@@ -2,14 +2,14 @@ name: Build & Apply PodDefaults manifests in KinD
 on:
   pull_request:
     paths:
-      - .github/workflows/admission_webhook_test.yaml
-      - apps/admission-webhook/upstream/**
-      - tests/gh-actions/kind-cluster.yaml
-      - tests/gh-actions/install_kind.sh
-      - tests/gh-actions/install_kustomize.sh
-      - tests/gh-actions/install_istio.sh
-      - tests/gh-actions/install_cert_manager.sh
-      - common/cert-manager/**
+    - .github/workflows/admission_webhook_test.yaml
+    - apps/admission-webhook/upstream/**
+    - tests/gh-actions/kind-cluster.yaml
+    - tests/gh-actions/install_kind.sh
+    - tests/gh-actions/install_kustomize.sh
+    - tests/gh-actions/install_istio.sh
+    - tests/gh-actions/install_cert_manager.sh
+    - common/cert-manager/**
 
 jobs:
   build:

diff --git a/.github/workflows/bentoml_test.yaml b/.github/workflows/bentoml_test.yaml
@@ -2,13 +2,13 @@ name: Build & Apply BentoML Yatai Stack manifests in KinD
 on:
   pull_request:
     paths:
-      - .github/workflows/bentoml_test.yaml
-      - tests/gh-actions/kind-cluster.yaml
-      - tests/gh-actions/install_kind.sh
-      - tests/gh-actions/install_kustomize.sh
-      - tests/gh-actions/install_cert_manager.sh
-      - common/cert-manager/**
-      - contrib/bentoml/**
+    - .github/workflows/bentoml_test.yaml
+    - tests/gh-actions/kind-cluster.yaml
+    - tests/gh-actions/install_kind.sh
+    - tests/gh-actions/install_kustomize.sh
+    - tests/gh-actions/install_cert_manager.sh
+    - common/cert-manager/**
+    - contrib/bentoml/**
 
 jobs:
   build:

diff --git a/.github/workflows/centraldashboard_test.yaml b/.github/workflows/centraldashboard_test.yaml
@@ -2,12 +2,12 @@ name: Build & Apply CentralDashboard manifests in KinD
 on:
   pull_request:
     paths:
-      - .github/workflows/centraldashboard_test.yaml
-      - apps/centraldashboard/upstream/**
-      - tests/gh-actions/kind-cluster.yaml
-      - tests/gh-actions/install_kind.sh
-      - tests/gh-actions/install_kustomize.sh
-      - tests/gh-actions/install_istio.sh
+    - .github/workflows/centraldashboard_test.yaml
+    - apps/centraldashboard/upstream/**
+    - tests/gh-actions/kind-cluster.yaml
+    - tests/gh-actions/install_kind.sh
+    - tests/gh-actions/install_kustomize.sh
+    - tests/gh-actions/install_istio.sh
 
 jobs:
   build:

diff --git a/.github/workflows/dex_test.yaml b/.github/workflows/dex_test.yaml
@@ -2,12 +2,12 @@ name: Build & Apply Dex manifests in KinD
 on:
   pull_request:
     paths:
-      - .github/workflows/dex_test.yaml
-      - common/dex/base/**
-      - tests/gh-actions/kind-cluster.yaml
-      - tests/gh-actions/install_kind.sh
-      - tests/gh-actions/install_kustomize.sh
-      - tests/gh-actions/install_istio.sh
+    - .github/workflows/dex_test.yaml
+    - common/dex/base/**
+    - tests/gh-actions/kind-cluster.yaml
+    - tests/gh-actions/install_kind.sh
+    - tests/gh-actions/install_kustomize.sh
+    - tests/gh-actions/install_istio.sh
 
 jobs:
   build:
@@ -33,3 +33,14 @@ jobs:
         cd common/dex
         kustomize build overlays/istio | kubectl apply -f -
         kubectl wait --for=condition=Ready pods --all --all-namespaces --timeout 180s
+
+    - name: port forward
+      run: |
+        ingress_gateway_service=$(kubectl get svc --namespace istio-system --selector="app=istio-ingressgateway" --output jsonpath='{.items[0].metadata.name}')
+        nohup kubectl port-forward --namespace istio-system svc/${ingress_gateway_service} 8080:80 &
+        while ! curl localhost:8080; do echo waiting for port-forwarding; sleep 1; done; echo port-forwarding ready
+
+    - name: test dex login
+      run: |
+        pip3 install requests
+        ./tests/gh-actions/test_dex_login.py
diff --git a/.github/workflows/jupyter_web_application_test.yaml b/.github/workflows/jupyter_web_application_test.yaml
@@ -2,12 +2,12 @@ name: Build & Apply JWA manifests in KinD
 on:
   pull_request:
     paths:
-      - .github/workflows/jupyter_web_application_test.yaml
-      - apps/jupyter/jupyter-web-app/upstream/**
-      - tests/gh-actions/kind-cluster.yaml
-      - tests/gh-actions/install_kind.sh
-      - tests/gh-actions/install_kustomize.sh
-      - tests/gh-actions/install_istio.sh
+    - .github/workflows/jupyter_web_application_test.yaml
+    - apps/jupyter/jupyter-web-app/upstream/**
+    - tests/gh-actions/kind-cluster.yaml
+    - tests/gh-actions/install_kind.sh
+    - tests/gh-actions/install_kustomize.sh
+    - tests/gh-actions/install_istio.sh
 
 jobs:
   build:

diff --git a/.github/workflows/katib_test.yaml b/.github/workflows/katib_test.yaml
@@ -2,14 +2,14 @@ name: Build & Apply Katib manifests in KinD
 on:
   pull_request:
     paths:
-      - .github/workflows/katib_test.yaml
-      - apps/katib/upstream/**
-      - tests/gh-actions/kind-cluster.yaml
-      - tests/gh-actions/install_kind.sh
-      - tests/gh-actions/install_kustomize.sh
-      - tests/gh-actions/install_istio.sh
-      - tests/gh-actions/install_cert_manager.sh
-      - common/cert-manager/**
+    - .github/workflows/katib_test.yaml
+    - apps/katib/upstream/**
+    - tests/gh-actions/kind-cluster.yaml
+    - tests/gh-actions/install_kind.sh
+    - tests/gh-actions/install_kustomize.sh
+    - tests/gh-actions/install_istio.sh
+    - tests/gh-actions/install_cert_manager.sh
+    - common/cert-manager/**
 
 jobs:
   build:

diff --git a/.github/workflows/kserve_cni_test.yaml b/.github/workflows/kserve_cni_test.yaml
@@ -2,69 +2,69 @@ name: Build & Apply KServe manifests in KinD, using istio CNI
 on:
   pull_request:
     paths:
-      - .github/workflows/kserve_cni_test.yaml
-      - tests/gh-actions/kind-cluster.yaml
-      - tests/gh-actions/install_kind.sh
-      - tests/gh-actions/install_kustomize.sh
-      - common/istio-cni-1-22/**
-      - tests/gh-actions/install_cert_manager.sh
-      - common/cert-manager/**
-      - tests/gh-actions/install_knative-cni.sh
-      - common/knative/**
-      - tests/gh-actions/install_kserve.sh
+    - .github/workflows/kserve_cni_test.yaml
+    - tests/gh-actions/kind-cluster.yaml
+    - tests/gh-actions/install_kind.sh
+    - tests/gh-actions/install_kustomize.sh
+    - common/istio-cni-1-22/**
+    - tests/gh-actions/install_cert_manager.sh
+    - common/cert-manager/**
+    - tests/gh-actions/install_knative-cni.sh
+    - common/knative/**
+    - tests/gh-actions/install_kserve.sh
 
 jobs:
   build:
     runs-on: ubuntu-latest
     steps:
-      - name: Checkout
-        uses: actions/checkout@v4
+    - name: Checkout
+      uses: actions/checkout@v4
 
-      - name: Install KinD
-        run: ./tests/gh-actions/install_kind.sh
+    - name: Install KinD
+      run: ./tests/gh-actions/install_kind.sh
 
-      - name: Create KinD Cluster
-        run: kind create cluster --config tests/gh-actions/kind-cluster.yaml
+    - name: Create KinD Cluster
+      run: kind create cluster --config tests/gh-actions/kind-cluster.yaml
 
-      - name: Install kustomize
-        run: ./tests/gh-actions/install_kustomize.sh
+    - name: Install kustomize
+      run: ./tests/gh-actions/install_kustomize.sh
 
-      - name: Create kubeflow namespace
-        run: kustomize build common/kubeflow-namespace/base | kubectl apply -f -
+    - name: Create kubeflow namespace
+      run: kustomize build common/kubeflow-namespace/base | kubectl apply -f -
 
-      - name: Install Istio CNI
-        run: ./tests/gh-actions/install_istio-cni.sh
+    - name: Install Istio CNI
+      run: ./tests/gh-actions/install_istio-cni.sh
 
-      - name: Install cert-manager
-        run: ./tests/gh-actions/install_cert_manager.sh
+    - name: Install cert-manager
+      run: ./tests/gh-actions/install_cert_manager.sh
 
-      - name: Install knative CNI
-        run: ./tests/gh-actions/install_knative-cni.sh
+    - name: Install knative CNI
+      run: ./tests/gh-actions/install_knative-cni.sh
 
-      - name: Build & Apply manifests
-        run: ./tests/gh-actions/install_kserve.sh
+    - name: Build & Apply manifests
+      run: ./tests/gh-actions/install_kserve.sh
 
-      - name: Create test namespace
-        run: kubectl create ns kserve-test
+    - name: Create test namespace
+      run: kubectl create ns kserve-test
 
-      - name: Setup python 3.9
-        uses: actions/setup-python@v4
-        with:
-          python-version: 3.9
+    - name: Setup python 3.9
+      uses: actions/setup-python@v4
+      with:
+        python-version: 3.9
 
-      - name: Install test dependencies
-        run: pip install -r ./contrib/kserve/tests/requirements.txt
+    - name: Install test dependencies
+      run: pip install -r ./contrib/kserve/tests/requirements.txt
 
-      - name: Port forward
-        run: |
-          INGRESS_GATEWAY_SERVICE=$(kubectl get svc --namespace istio-system --selector="app=istio-ingressgateway" --output jsonpath='{.items[0].metadata.name}')
-          nohup kubectl port-forward --namespace istio-system svc/${INGRESS_GATEWAY_SERVICE} 8080:80 &
+    - name: Port forward
+      run: |
+        INGRESS_GATEWAY_SERVICE=$(kubectl get svc --namespace istio-system --selector="app=istio-ingressgateway" --output jsonpath='{.items[0].metadata.name}')
+        nohup kubectl port-forward --namespace istio-system svc/${INGRESS_GATEWAY_SERVICE} 8080:80 &
 
-      - name: Run kserve tests
-        run: |
-          export KSERVE_INGRESS_HOST_PORT=localhost:8080
-          cd ./contrib/kserve/tests && pytest .
+    - name: Run kserve tests
+      run: |
+        export KSERVE_INGRESS_HOST_PORT=localhost:8080
+        cd ./contrib/kserve/tests && pytest .
 
-      - name: Run kserve models webapp test
-        run: |
-          kubectl wait --for=condition=Available --timeout=300s -n kubeflow deployment/kserve-models-web-app
+    - name: Run kserve models webapp test
+      run: |
+        kubectl wait --for=condition=Available --timeout=300s -n kubeflow deployment/kserve-models-web-app