Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated go version #1457

Closed
wants to merge 1 commit into from
Closed

Conversation

Ayush9026
Copy link

@Ayush9026 Ayush9026 commented Feb 18, 2024

Which issue is resolved by this Pull Request:
Resolves #kubeflow/pipelines#10487

Description of your changes:
KFP is using go version 1.13 which is very old. Although the image is using go 1.20, we should update the go.mod and the core program to go 1.21

Checklist:

Copy link

google-cla bot commented Feb 18, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Ayush9026
Once this PR has been reviewed and has the lgtm label, please assign pugangxa for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Member

@Tomcli Tomcli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/close
This PR is failing on the e2e test. We already moved to go 1.21 in the v2 branch. For master branch we are maintaining the kfp-tekton v1 version. As for upstream kfp, due to ci issue, I upgraded the upstream kfp to 1.20 for now which unblock the Tekton backend merge.

@google-oss-prow google-oss-prow bot closed this Mar 20, 2024
Copy link

@Tomcli: Closed this PR.

In response to this:

/close
We already moved to go 1.21 in the v2 branch. For master branch we are maintaining the kfp-tekton v1 version. As for upstream kfp, due to ci issue, I upgraded the upstream kfp to 1.20 for now which unblock the Tekton backend merge.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants