Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pipelineloop): Update pipelineloop v2 to have failed and cancelled status #1445

Merged
merged 2 commits into from
Jan 5, 2024
Merged

feat(pipelineloop): Update pipelineloop v2 to have failed and cancelled status #1445

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1d4b95b
update pipelineloop v2 to have failed and cancelled status
Tomcli Jan 4, 2024
687de02
fix execution id update bug
Tomcli Jan 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion tekton-catalog/pipeline-loops/pkg/reconciler/pipelinelooprun/pipelinelooprun.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -433,18 +433,36 @@ func (c *Reconciler) reconcile(ctx context.Context, customRun *tektonv1beta1.Cus
}
// CustomRun is cancelled, just cancel all the running instance and return
if customRun.IsCancelled() {
var DAGStatus pb.Execution_State
if len(failedPrs) > 0 {
customRun.Status.MarkCustomRunFailed(pipelineloopv1alpha1.PipelineLoopRunReasonFailed.String(),
"CustomRun %s/%s was failed",
customRun.Namespace, customRun.Name)
DAGStatus = pb.Execution_FAILED
} else {
reason := pipelineloopv1alpha1.PipelineLoopRunReasonCancelled.String()
if customRun.HasTimedOut(c.clock) { // This check is only possible if we are on tekton 0.27.0 +
reason = string(tektonv1beta1.CustomRunReasonTimedOut)
}
customRun.Status.MarkCustomRunFailed(reason, "CustomRun %s/%s was cancelled", customRun.Namespace, customRun.Name)
DAGStatus = pb.Execution_CANCELED
}
if c.runKFPV2Driver == "true" {
options, err := kfptask.ParseParams(customRun)
if err != nil {
logger.Errorf("Run %s/%s is invalid because of %s", customRun.Namespace, customRun.Name, err)
customRun.Status.MarkCustomRunFailed(kfptask.ReasonFailedValidation,
"Run can't be run because it has an invalid param - %v", err)
return err
}
DAGErr := kfptask.UpdateDAGPublisher(ctx, options, DAGStatus)
if err != nil {
logger.Errorf("kfp publisher failed when reconciling Run %s/%s: %v", customRun.Namespace, customRun.Name, DAGErr)
customRun.Status.MarkCustomRunFailed(kfptask.ReasonDriverError,
"kfp publisher execution failed: %v", DAGErr)
return DAGErr
}
}

for _, currentRunningPr := range currentRunningPrs {
logger.Infof("CustomRun %s/%s is cancelled. Cancelling PipelineRun %s.", customRun.Namespace, customRun.Name, currentRunningPr.Name)
if _, err := c.pipelineClientSet.TektonV1().PipelineRuns(customRun.Namespace).Patch(ctx, currentRunningPr.Name, types.JSONPatchType, cancelPatchBytes, metav1.PatchOptions{}); err != nil {
Expand Down
Loading