Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add constants for GatewayClass conditions #99

Merged
merged 3 commits into from
Jan 7, 2025
Merged

feat: add constants for GatewayClass conditions #99

merged 3 commits into from
Jan 7, 2025

Conversation

aharbis
Copy link
Contributor

@aharbis aharbis commented Jan 7, 2025 •
edited
Loading

  • Add types GatewayClassConditionType and GatewayClassConditionReason for working with GatewayClass conditions.
  • Note: the conditions vary between standard and experimental channels, although I didn't see any precedent for handling this in update.sh so I opted to just rebind the variables later on to add the experimental ones.
  • Unrelated: resolves some clippy warnings in xtask/src/main.rs.

Fixes: #98

@aharbis aharbis force-pushed the gateway-class-condition-types branch from 4065235 to 1f942e9 Compare January 7, 2025 18:32
aharbis
aharbis commented Jan 7, 2025
View reviewed changes
update.sh Outdated Show resolved Hide resolved
aharbis and others added 2 commits January 7, 2025 13:42
@aharbis
fix: address some clippy lints
813b9e1 
Signed-off-by: Aidan Harbison <[email protected]>
@shaneutt @aharbis
chore: experimental constants as additive from standard
8accb86 
Co-authored-by: Aidan Harbison <[email protected]>
Signed-off-by: Shane Utt <[email protected]>
shaneutt
shaneutt approved these changes Jan 7, 2025
View reviewed changes
Copy link
Member

@shaneutt shaneutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Thank you for taking care of this!

update.sh Outdated Show resolved Hide resolved
@shaneutt shaneutt enabled auto-merge (squash) January 7, 2025 21:39
@shaneutt shaneutt disabled auto-merge January 7, 2025 21:41
@shaneutt shaneutt merged commit cd36c67 into kube-rs:main Jan 7, 2025
3 checks passed
@shaneutt shaneutt added the bug Something isn't working label Jan 7, 2025
@shaneutt shaneutt added this to the Initial Pre-Release milestone Jan 7, 2025
@aharbis aharbis deleted the gateway-class-condition-types branch January 7, 2025 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shaneutt shaneutt shaneutt approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
gateway-api-rs
Status: Done
Milestone
Initial Pre-Release
Development

Successfully merging this pull request may close these issues.

Missing enums for GatewayClassConditionType and GatewayClassConditionReason
2 participants
@aharbis @shaneutt