fix(Dropdown): comment will be treat as VNode in vue3, close #975

ksc-fe · Mar 7, 2024 · aec133d · aec133d
1 parent 7efcdda
commit aec133d
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/components/dropdown/dropdown.ts b/components/dropdown/dropdown.ts
@@ -99,7 +99,7 @@ export class Dropdown<
         // ignore whitespaces between elements in Vue
         if ((this as any).$isVue || (this as any).$isVueNext) {
             if (Array.isArray(children)) {
-                children = children.filter(child => child !== ' ');
+                children = children.filter(child => child !== ' ' && child /* comment is null in vue3 */);
             }
         }
         if (process.env.NODE_ENV !== 'production') {

diff --git a/packages/kpc-vue-next/__tests__/components/dropdown.spec.ts b/packages/kpc-vue-next/__tests__/components/dropdown.spec.ts
@@ -27,6 +27,7 @@ describe('Dropdown', () => {
                             <DropdownItem>item 2</DropdownItem>
                             <DropdownItem>item 3</DropdownItem>
                         </DropdownMenu>
+                        <!-- comment -->
                     </Dropdown>
                 </div>
             `,