fix: externalRepresentation condition to validate if key is private should be d not prime #1060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hould be d not prime I got to this issue recently where the library was giving me a public key DER when the key had a d and no primes, this is misleading since an RSA key can have d and no primes. This function should acess if the key is private through the d, if it requires the primes it should return an error. As part of this PR I also made the primes public, they are already a let, making them public makes the API more accessible to deal for example if I want to build a JWK with primes included.
beatt83
added a commit
to beatt83/jose-swift
that referenced
this pull request
Dec 7, 2024
PR submitted for the fix krzyzanowskim/CryptoSwift#1060
beatt83
added a commit
to beatt83/jose-swift
that referenced
this pull request
Dec 7, 2024
PR submitted for the fix krzyzanowskim/CryptoSwift#1060
beatt83
added a commit
to beatt83/jose-swift
that referenced
this pull request
Dec 7, 2024
PR submitted for the fix krzyzanowskim/CryptoSwift#1060
|
@beatt83 why this PR got closed? |
|
I reopen and let @nathanfallet to weight in about the change. |
|
Hey @krzyzanowskim. It was a weird behavior with GitHub, since I tagged this PR in a commit and then merged on my library that PR it closed this one. Thanks for reopening. :) |
|
Hey @krzyzanowskim . Is there any update around this? :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
I got to this issue recently where the library was giving me a public key DER when the key had a d and no primes, this is misleading since an RSA key can have d and no primes. This function should acess if the key is private through the d, if it requires the primes it should return an error.
As part of this PR I also made the primes public, they are already a let, making them public makes the API more accessible to deal for example if I want to build a JWK with primes included.
It is quite difficult right now if you want to expose this keys to other coding types since the primes are private, and as far as I know there is no reason for that.
Checklist:
Changes proposed in this pull request: