Fixes the critical alerts exception with the start_time > end_time #551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tullio Sebastiani <[email protected]>
tsebastiani
requested review from
chaitanyaenr and
paigerube14
and removed request for
chaitanyaenr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If datetime.now() is defined as default parameter value, the date is calculated at the moment the intepreter defines the function and not when the function is called (as I thought), that's the reason why the start_time is considered greater than the end_time by the prometheus API as explained here.
This change fixes the issue.
This has been enforced also on the krkn-lib side, but this fix will solve the problem immediately without the need of updating to the next version.