Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployer -> Deployers #537

Merged
merged 1 commit into from
Jan 10, 2024
Merged

Deployer -> Deployers #537

merged 1 commit into from
Jan 10, 2024

Conversation

paigerube14
Copy link
Collaborator

@paigerube14 paigerube14 commented Jan 2, 2024

Arcaflow scenarios of deployer to deployers

Still need to test

Using documentation updates from here

@jaredoconnell
Copy link
Contributor

deployer isn't just replaced with deployers. You also need to add the deployer type. In the case of Kubernetes, that's image. So it should be something like:

deployers:
  image:
    connection: {}
    type: kubernetes

@jaredoconnell
Copy link
Contributor

I missed one other thing. We made type less ambiguous by renaming it to deployer_name. This was a one-time change. I don't expect major renames in the near future.

Copy link
Contributor

@jaredoconnell jaredoconnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Untested, but all changes look good.

Copy link
Collaborator

@chaitanyaenr chaitanyaenr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@paigerube14 paigerube14 force-pushed the deployers branch 3 times, most recently from a3858cd to 2d8c24b Compare January 9, 2024 18:39
@tsebastiani tsebastiani merged commit 462f93a into krkn-chaos:main Jan 10, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants