Metrics #147
Open
Metrics #147
+26
−51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paigerube14
commented
Feb 4, 2025
| @@ -79,7 +79,7 @@ def process_prom_query_in_range( | |||
| query=query, | |||
| start_time=start_time, | |||
| end_time=end_time, | |||
| step=f"{granularity}s", | |||
| step=f"10s", | |||
There was a problem hiding this comment.
need to find a better way to calculate granularity. Every 1 second seems a bit high. Think this is still even too high
Signed-off-by: Paige Patton <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding in new configuration of metrics
Also trying to add in better logging when elastic upload fails, need to still validate that this data is clear enough. NOTE: I do find it very difficult to go back and forth between krkn output and a tmp output file to see why the data might not have been uploaded