Adding node id to affected node info #146
Open
+32
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paigerube14
force-pushed
the
node_timing
branch
from
2e1b4fe to
e3fbdeb
Compare
Signed-off-by: Paige Patton <[email protected]>
paigerube14
force-pushed
the
node_timing
branch
from
dbb69a0 to
73c3cb9
Compare
|
@chaitanyaenr can you please take a look, this is blocking the node tests from passing @tsebastiani did notice that the tests are seeming pretty inconsistent. I don't think anything I changed here should effect each of the tests that are failing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the cluster shut down scenario, we do not easily have the node name to find the affected node properly. Adding the node instance id will help easily be able to get the details of the affected node