Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Plugin SDK #36

Merged
merged 10 commits into from
Jul 1, 2024
Merged

Update Plugin SDK #36

merged 10 commits into from
Jul 1, 2024

Conversation

mfleader
Copy link
Contributor

@mfleader mfleader commented Jun 7, 2024

@chaitanyaenr chaitanyaenr requested a review from tsebastiani June 7, 2024 15:16
@mfleader mfleader marked this pull request as draft June 7, 2024 15:48
@mfleader mfleader marked this pull request as ready for review June 10, 2024 14:43
Copy link
Collaborator

@tsebastiani tsebastiani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

Copy link
Collaborator

@tsebastiani tsebastiani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could eventually setup a test environment with kind to run the plugin as I did for krkn-lib https://github.com/krkn-chaos/krkn-lib/blob/a6c6ab1998b2e834f4897619a39960911a89d102/.github/workflows/build.yaml#L21. Thoughts (we can think to do that after this PR is merged)?

Copy link
Collaborator

@tsebastiani tsebastiani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since krkn ,krkn-lib and kill-pod plugin are depending from arcaflow-plugin-sdk, when one of these components are updated there is a dependency hell that needs to be solved (as I did to test the PR) that's why we need to separate this plugin (and hopefully the others) from the krkn codebase ASAP and keep them in containers running in proper workflows!

mfleader added 9 commits June 13, 2024 16:48
Signed-off-by: Matthew F Leader <[email protected]>
Signed-off-by: Matthew F Leader <[email protected]>
Signed-off-by: Matthew F Leader <[email protected]>
Signed-off-by: Matthew F Leader <[email protected]>
Signed-off-by: Matthew F Leader <[email protected]>
Signed-off-by: Matthew F Leader <[email protected]>
Signed-off-by: Matthew F Leader <[email protected]>
@tsebastiani tsebastiani merged commit dd7c879 into krkn-chaos:main Jul 1, 2024
2 checks passed
@mfleader mfleader deleted the updates branch July 9, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants