fix-#275: Correct the icon color in dark mode #441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Hey @shivansh84ya! Thanks for sticking to the guidelines! High five! 🙌🏻 |
|
Kindly attach image @shivansh84ya in PR description of both themes |
|
So that i can merge this @shivansh84ya |
|
Hey @shivansh84ya! Thanks for sticking to the guidelines! High five! 🙌🏻 |
|
Hey @krishnaacharyaa , |
krishnaacharyaa
approved these changes
Jul 3, 2024
There was a problem hiding this comment.
Thank you @shivansh84ya, thank you for the quick and sweet solution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR aims to correct the icon color in dark mode to ensure consistency with the theme.
Description
The current implementation of the icon color in dark mode does not match the overall theme, resulting in a less cohesive user interface. This PR addresses this issue by inverting the icon color in dark mode to ensure it aligns with the theme's color scheme.
Image
Issue(s) Addressed
Closes #275 Correct the icon color in dark mode
Prerequisites