fix-#432: Bug Fixed #438

kapilG0 · 2024-06-27T17:25:05Z

Summary

Fixed header for signup and login page in mobile

Description

Header fixed for signup and login page

Images

Issue(s) Addressed

Closes #432

Prerequisites

Have you followed all the CONTRIBUTING GUIDELINES?

vercel · 2024-06-27T17:25:09Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
wanderlust	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 28, 2024 0:25am
wanderlust-backend	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 28, 2024 0:25am

github-actions · 2024-06-27T17:25:17Z

Hey @kapilG0! Thanks for sticking to the guidelines! High five! 🙌🏻

krishnaacharyaa

Thank you @kapilG0 , Kindly address the review comments and add snapshots of the desktop view even to cross check.

frontend/src/pages/signin-page.tsx

frontend/src/pages/signup-page.tsx

krishnaacharyaa · 2024-06-28T06:22:43Z

@kapilG0 take some time, and go through https://tailwindcss.com/docs/responsive-design , and get back,
The solution shouldn't be more than 6 to 8 characters meaning it is that minor change, you don't have to create new custom classes and stuff. And forget about the tablet screen,

The task is not to the existing code base of desktop, only in the mobile it needs to be fixed, figure it out

kapilG0 · 2024-06-28T08:11:03Z

@kapilG0 take some time, and go through https://tailwindcss.com/docs/responsive-design , and get back, The solution shouldn't be more than 6 to 8 characters meaning it is that minor change, you don't have to create new custom classes and stuff. And forget about the tablet screen,

The task is not to the existing code base of desktop, only in the mobile it needs to be fixed, figure it out

Hello @krishnaacharyaa based on above documentation i changed code .please check below images if it is fine then i will raise pr.
for mobile

for ipad

for desktop

krishnaacharyaa · 2024-06-28T08:36:33Z

Hello @krishnaacharyaa based on above documentation i changed code

Kindly push it, so that I can tell if you are on the right track

kapilG0 · 2024-06-28T08:59:40Z

Hello @krishnaacharyaa based on above documentation i changed code

Kindly push it, so that I can tell if you are on the right track

i have pushed please check

krishnaacharyaa · 2024-06-28T09:13:23Z

frontend/src/pages/signup-page.tsx

@@ -68,7 +67,7 @@ function Signup() {
    <div className="flex-grow cursor-default bg-white py-4 dark:bg-dark-card">
      <div className="m-4 mb-4 flex justify-center">
        <div className="flex w-full items-center justify-center">
-          <h2 className="w-3/4 pl-48 text-center text-lg font-bold text-black dark:text-dark-primary sm:text-xl">
+          <h2 className="text-center text-lg font-bold text-black dark:text-dark-primary sm:w-2/4 sm:pl-2 sm:text-xl lg:w-3/4 lg:pl-48">
            Sign up to WanderLust


you mean to say w-2/4 text-xl md:w-3/4 md:pl-48?

You are almost there, figure out why i said the above instead of sm:w-2/4 sm:pl-2 sm:text-xl lg:w-3/4 lg:pl-48

ps: We are focusing on mobile and devices with greater than mobile width screen . i.e md: and default should only be used, you can see the repo, no where we are using the lg:, you have solution here, please change it and try to understand why this change i suggested :)

you mean to say w-2/4 text-xl md:w-3/4 md:pl-48?

You are almost there, figure out why i said the above instead of sm:w-2/4 sm:pl-2 sm:text-xl lg:w-3/4 lg:pl-48

ps: We are focusing on mobile and devices with greater than mobile width screen . i.e md: and default should only be used, you can see the repo, no where we are using the lg:, you have solution here, please change it and try to understand why this change i suggested :)

ok now i understood by default it will be desktop and for mobile and screen small than desktop we should add sm,md for that right ?

ok now i understood by default it will be desktop and for mobile and screen small than desktop we should add sm,md for that right ?

Default is for mobile @kapilG0 in tailwind-css, in bootstrap it was what you are saying

ok now i understood by default it will be desktop and for mobile and screen small than desktop we should add sm,md for that right ?

Default is for mobile @kapilG0 in tailwind-css, in bootstrap it was what you are saying

oh ok. thank you for clearing and helping me a lot in that . i have never use tailwind i will check some resource for that. i am modifying my changes . very sorry

No problem @kapilG0 , the hunger for learning, motivated me to help you :)

No problem @kapilG0 , the hunger for learning, motivated me to help you :)

thanks @krishnaacharyaa

frontend/src/pages/signin-page.tsx

krishnaacharyaa · 2024-06-28T10:37:30Z

frontend/src/pages/signin-page.tsx

@@ -73,7 +72,7 @@ function signin() {
    <div className="flex-grow cursor-default bg-white py-4 dark:bg-dark-card">
      <div className="m-4 mb-4 flex justify-center">
        <div className="flex w-full items-center justify-center">
-          <h2 className="w-3/4 pl-48 text-center text-lg font-bold text-black dark:text-dark-primary sm:text-xl">
+          <h2 className="text-center text-lg font-bold text-black dark:text-dark-primary sm:w-2/4 sm:pl-2 sm:text-xl md:w-3/4 md:pl-48">
            Sign in to WanderLust


As discussed you would have to remove sm: because mobile screen would be less with than sm: and we need this for mobile screen right? which is default. so why do we need to add sm: correct?

As discussed you would have to remove sm: because mobile screen would be less with than sm: and we need this for mobile screen right? which is default. so why do we need to add sm: correct?

yup understood @krishnaacharyaa

krishnaacharyaa

Thank you LGTM

fix-krishnaacharyaa#432: Bug Fixed

6d687c3

vercel bot deployed to Preview – wanderlust June 27, 2024 17:25 View deployment

kapilG0 mentioned this pull request Jun 27, 2024

[BUG] header should be displayed properly in signup and login page #432

Closed

1 task

vercel bot deployed to Preview – wanderlust-backend June 27, 2024 17:26 View deployment

krishnaacharyaa requested changes Jun 27, 2024

View reviewed changes

frontend/src/pages/signin-page.tsx Show resolved Hide resolved

frontend/src/pages/signup-page.tsx Show resolved Hide resolved

fix-krishnaacharyaa#432: Fixed Bug

604df24

vercel bot deployed to Preview – wanderlust-backend June 28, 2024 06:04 View deployment

vercel bot deployed to Preview – wanderlust June 28, 2024 06:05 View deployment

fix-krishnaacharyaa#432: header bug fixed

32388f7

vercel bot deployed to Preview – wanderlust-backend June 28, 2024 08:54 View deployment

vercel bot deployed to Preview – wanderlust June 28, 2024 08:54 View deployment

krishnaacharyaa reviewed Jun 28, 2024

View reviewed changes

frontend/src/pages/signin-page.tsx Show resolved Hide resolved

Update signin-page.tsx

9a2514a

vercel bot deployed to Preview – wanderlust June 28, 2024 09:22 View deployment

vercel bot deployed to Preview – wanderlust-backend June 28, 2024 09:22 View deployment

Update signup-page.tsx

66f7f76

vercel bot deployed to Preview – wanderlust-backend June 28, 2024 09:23 View deployment

vercel bot deployed to Preview – wanderlust June 28, 2024 09:23 View deployment

krishnaacharyaa reviewed Jun 28, 2024

View reviewed changes

Update signin-page.tsx

7d1a0ca

vercel bot deployed to Preview – wanderlust-backend June 28, 2024 12:23 View deployment

vercel bot deployed to Preview – wanderlust June 28, 2024 12:23 View deployment

Update signup-page.tsx

460f4a5

vercel bot deployed to Preview – wanderlust June 28, 2024 12:24 View deployment

vercel bot deployed to Preview – wanderlust-backend June 28, 2024 12:25 View deployment

krishnaacharyaa approved these changes Jun 28, 2024

View reviewed changes

krishnaacharyaa merged commit db4b416 into krishnaacharyaa:main Jun 28, 2024
3 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix-#432: Bug Fixed #438

fix-#432: Bug Fixed #438

kapilG0 commented Jun 27, 2024

vercel bot commented Jun 27, 2024 •

edited

Loading

github-actions bot commented Jun 27, 2024

krishnaacharyaa left a comment

krishnaacharyaa commented Jun 28, 2024

kapilG0 commented Jun 28, 2024

krishnaacharyaa commented Jun 28, 2024 •

edited

Loading

kapilG0 commented Jun 28, 2024

krishnaacharyaa Jun 28, 2024

kapilG0 Jun 28, 2024

krishnaacharyaa Jun 28, 2024

kapilG0 Jun 28, 2024 •

edited

Loading

krishnaacharyaa Jun 28, 2024

kapilG0 Jun 28, 2024

krishnaacharyaa Jun 28, 2024

kapilG0 Jun 28, 2024

krishnaacharyaa left a comment

fix-#432: Bug Fixed #438

fix-#432: Bug Fixed #438

Conversation

kapilG0 commented Jun 27, 2024

Summary

Description

Images

Issue(s) Addressed

Prerequisites

vercel bot commented Jun 27, 2024 • edited Loading

github-actions bot commented Jun 27, 2024

krishnaacharyaa left a comment

Choose a reason for hiding this comment

krishnaacharyaa commented Jun 28, 2024

kapilG0 commented Jun 28, 2024

krishnaacharyaa commented Jun 28, 2024 • edited Loading

kapilG0 commented Jun 28, 2024

krishnaacharyaa Jun 28, 2024

Choose a reason for hiding this comment

kapilG0 Jun 28, 2024

Choose a reason for hiding this comment

krishnaacharyaa Jun 28, 2024

Choose a reason for hiding this comment

kapilG0 Jun 28, 2024 • edited Loading

Choose a reason for hiding this comment

krishnaacharyaa Jun 28, 2024

Choose a reason for hiding this comment

kapilG0 Jun 28, 2024

Choose a reason for hiding this comment

krishnaacharyaa Jun 28, 2024

Choose a reason for hiding this comment

kapilG0 Jun 28, 2024

Choose a reason for hiding this comment

krishnaacharyaa left a comment

Choose a reason for hiding this comment

vercel bot commented Jun 27, 2024 •

edited

Loading

krishnaacharyaa commented Jun 28, 2024 •

edited

Loading

kapilG0 Jun 28, 2024 •

edited

Loading