Fix small issues #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the double function definition.
Define the void FairDetector::ProcessHits() function, which calls the depracated Bool_t ProcessHits(FairVolume*) of derived classes. Update the FairMCApplication to match the update of the VMC: introduction of EndOfEvent function called before the TVirtualMCSensitiveDetectors->EndOfEvent(). Implement the temporary FairMCApplication::GetFairVolume() function to keep the backward compability. Cleanup of FairModule, FairMCApplication double code.
FairRoot allows for construction of clones volumes
using the volume_name#{clone_number} scheme.
Changing FairMCApplication::ConstructSensitiveDetectors()
to support this.
The function is now called from VMC directly.
karabowi
force-pushed
the
feature_sensitive_volumes
branch
2 times, most recently
from
a96f67f to
2259768
Compare
karabowi
force-pushed
the
feature_sensitive_volumes
branch
from
2259768 to
2ab950f
Compare
karabowi
force-pushed
the
feature_sensitive_volumes
branch
4 times, most recently
from
e3810cc to
e34b574
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't call FairModule::initialize() from FairMCApplication any longer. The function is now called directly from VMC. Calling the function twice results in a crash when executing a transport simulation with CbmRoot.
Don't use FairVolume any longer in the ProcessHits() function of the detector implementation since it doesn't exist any longer in that scope. Access the needed information directly from VMC.