Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace env_logger with simple_logger #42

Merged
merged 10 commits into from
Feb 10, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .github/workflows/rpackage.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ jobs:
- { os: ubuntu-latest, r: "oldrel-1" }
- { os: ubuntu-latest, r: "oldrel-2" }


env:
GITHUB_PAT: ${{ secrets.GITHUB_TOKEN }}
R_KEEP_PKG_SOURCE: yes
Expand All @@ -57,5 +56,5 @@ jobs:
- uses: r-lib/actions/check-r-package@v2
with:
upload-snapshots: true
build_args: 'c("--no-manual","--compact-vignettes=gs+qpdf")'
build_args: 'c("--no-manual", "--compact-vignettes=gs+qpdf")'
working-directory: "./antidotum/tergo"
11 changes: 7 additions & 4 deletions antidotum/tergo/R/styling.R
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
#' @examples
#' style()
#' style(config_file = "tergo.toml", configuration = list())
#'
style <- function(config_file = "tergo.toml", configuration = list(), ...) {
style_pkg(path = getwd(), config_file = config_file, configuration = configuration)
invisible(NULL)
Expand Down Expand Up @@ -46,6 +47,7 @@ style <- function(config_file = "tergo.toml", configuration = list(), ...) {
#' @examples
#' style_pkg()
#' style_pkg(path = "./tergo", config_file = "custom_tergo.toml", verbose = TRUE)
#'
style_pkg <- function(path = ".",
config_file = "tergo.toml",
configuration = list(),
Expand Down Expand Up @@ -180,6 +182,7 @@ style_pkg <- function(path = ".",
#' close(file_conn)
#' style_file(file = tmp, configuration = list())
#' unlink(tmp)
#'
style_file <- function(file, configuration = list()) {
ignored_paths <- configuration$exclusion_list
if (!is.null(ignored_paths)) {
Expand Down Expand Up @@ -256,11 +259,11 @@ style_file_internal <- function(file, configuration, ignored_paths) {
#'
#' @export
#' @examples
#' code <- "function(){}"
#' style_text(code)
#' code <- "a+b"
#' styled <- style_text(code)
#' code <- c("a+b", "A<-7")
#' styled <- style_text(code)
#'
#' code <- c("function(){}", "A<-7")
#' style_text(code)
style_text <- function(text, configuration = list()) {
vapply(
X = text,
Expand Down
1 change: 1 addition & 0 deletions antidotum/tergo/man/style.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions antidotum/tergo/man/style_file.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions antidotum/tergo/man/style_pkg.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions antidotum/tergo/man/style_text.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion antidotum/tergo/src/rust/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ name = "tergo"

[dependencies]
tergo-lib = "0.2.9"
toml = "0.8.19"
toml = "0.8.20"
extendr-api = "*"

[workspace]
Expand Down
Empty file modified antidotum/tergo/src/rust/vendor.sh
100644 → 100755
Empty file.
Binary file modified antidotum/tergo/src/rust/vendor.tar.xz
Binary file not shown.
10 changes: 7 additions & 3 deletions aqua/Cargo.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "tergo-tokenizer"
version = "0.2.3"
version = "0.2.4"
edition = "2021"
authors = ["Konrad Pagacz [email protected]"]
description = "R language tokenizer"
Expand All @@ -10,5 +10,9 @@ repository = "https://github.com/kpagacz/tergo/tree/main/aqua"
# See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html

[dependencies]
env_logger = "0.11.5"
log = "0.4.21"
log = "0.4.25"

[dev-dependencies]
simple_logger = { version = "5.0.0", default-features = false, features = [
"timestamps",
] }
5 changes: 4 additions & 1 deletion aqua/tests/tokenizer_tests.rs
Original file line number Diff line number Diff line change
@@ -1,7 +1,10 @@
use tergo_tokenizer::{tokenizer::Tokenizer, tokens::Token};

fn log_init() {
let _ = env_logger::builder().is_test(true).try_init();
match simple_logger::init_with_env() {
Ok(_) => {}
Err(err) => println!("Error initializing logger: {:?}", err),
}
}

#[test]
Expand Down
18 changes: 11 additions & 7 deletions balnea/Cargo.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "tergo-lib"
version = "0.2.10"
version = "0.2.11"
edition = "2021"
description = "A tool to format R code"
license = "MIT"
Expand All @@ -12,9 +12,13 @@ repository = "https://github.com/kpagacz/tergo/tree/main/balnea"
path = "src/lib.rs"

[dependencies]
tokenizer = { package = "tergo-tokenizer", path = "../aqua", version = "0.2.3" }
parser = { package = "tergo-parser", path = "../spongia", version = "0.2.4" }
formatter = { package = "tergo-formatter", path = "../unguentum", version = "0.2.9" }
log = "0.4.21"
env_logger = "0.11.3"
serde = { version = "1.0.210", features = ["derive"] }
tokenizer = { package = "tergo-tokenizer", path = "../aqua", version = "0.2.4" }
parser = { package = "tergo-parser", path = "../spongia", version = "0.2.5" }
formatter = { package = "tergo-formatter", path = "../unguentum", version = "0.2.10" }
log = "0.4.25"
serde = { version = "1.0.217", features = ["derive"] }

[dev-dependencies]
simple_logger = { version = "5.0.0", features = [
"timestamps",
], default-features = false }
6 changes: 5 additions & 1 deletion balnea/tests/format_integration.rs
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,11 @@ use formatter::config::{AllowNlAfterAssignment, EmbracingOpNoNl, Indent, LineLen
use tergo_lib::{tergo_format, Config};

fn log_init() {
let _ = env_logger::builder().is_test(true).try_init();
let res = simple_logger::init_with_env();
match res {
Ok(_) => {}
Err(err) => println!("Failed to initialize logger {:?}", err),
}
}

macro_rules! comparison_test {
Expand Down
9 changes: 6 additions & 3 deletions scopa/Cargo.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "scopa"
version = "0.1.1"
version = "0.1.2"
edition = "2021"

[lib]
Expand All @@ -9,7 +9,10 @@ path = "./src/lib.rs"

[dependencies]
wit-bindgen = "0.32.0"
tergo-lib = { path = "../balnea", version = "0.2.10" }
tergo-lib = { path = "../balnea", version = "0.2.11" }
simple_logger = { version = "5.0.0", default-features = false, features = [
"timestamps",
] }

[dev-dependencies]
wasm-tools = "1.217.0"
wasm-tools = "1.217.1"
1 change: 1 addition & 0 deletions scopa/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ struct Tergo;

impl Guest for Tergo {
fn format(code: String) -> Result<String, String> {
simple_logger::init_with_env().map_err(|err| format!("Error initializing logger: {:?}", err))?;
tergo_format(&code, None)
}
}
Expand Down
10 changes: 5 additions & 5 deletions spongia/Cargo.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "tergo-parser"
version = "0.2.4"
version = "0.2.5"
edition = "2021"
license = "MIT"
description = "Parser for tergo"
Expand All @@ -10,10 +10,10 @@ repository = "https://github.com/kpagacz/tergo/tree/main/spongia"

[dependencies]
nom = "7.1.3"
nom_locate = "4.2.0"
anyhow = "1.0.81"
tokenizer = { package = "tergo-tokenizer", path = "../aqua", version = "0.2.3" }
tokenizer = { package = "tergo-tokenizer", path = "../aqua", version = "0.2.4" }
log = "0.4.21"

[dev-dependencies]
env_logger = "0.11.3"
simple_logger = { version = "5.0.0", default-features = false, features = [
"timestamps",
] }
5 changes: 4 additions & 1 deletion spongia/src/compound.rs
Original file line number Diff line number Diff line change
Expand Up @@ -247,7 +247,10 @@ mod tests {
use tokenizer::Token::*;

fn log_init() {
let _ = env_logger::builder().is_test(true).try_init();
match simple_logger::init_with_env() {
Ok(_) => {}
Err(err) => println!("Error initializing logger: {:?}", err),
}
}

#[test]
Expand Down
5 changes: 4 additions & 1 deletion spongia/tests/integration_test.rs
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,10 @@ use tergo_parser::{parse, pre_parse};
use tokenizer::Tokenizer;

fn log_init() {
let _ = env_logger::builder().is_test(true).try_init();
match simple_logger::init_with_env() {
Ok(_) => {}
Err(err) => println!("Error initializing logger: {:?}", err),
}
}

#[test]
Expand Down
12 changes: 7 additions & 5 deletions tergo/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,10 @@ description = "Format code written in R"
repository = "https://github.com/kpagacz/tergo/"

[dependencies]
clap = { version = "4.5.17", features = ["derive"] }
env_logger = "0.11.5"
log = "0.4.22"
tergo-lib = { path = "../balnea", version = "0.2.9" }
toml = "0.8.19"
clap = { version = "4.5.18", features = ["derive"] }
log = "0.4.25"
simple_logger = { version = "5.0.0", default-features = false, features = [
"timestamps",
] }
tergo-lib = { path = "../balnea", version = "0.2.11" }
toml = "0.8.20"
5 changes: 4 additions & 1 deletion tergo/src/main.rs
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,10 @@ fn main() {
if std::env::var("RUST_LOG").is_err() {
std::env::set_var("RUST_LOG", "info");
}
env_logger::init();
match simple_logger::init_with_env() {
Ok(_) => {}
Err(err) => println!("Failed to initialize logger: {:?}", err),
}
let cli = Cli::parse();

let path = PathBuf::from_str(&cli.path).unwrap();
Expand Down
14 changes: 8 additions & 6 deletions unguentum/Cargo.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "tergo-formatter"
version = "0.2.9"
version = "0.2.10"
edition = "2021"
license = "MIT"
description = "Formatter for tergo"
Expand All @@ -9,11 +9,13 @@ repository = "https://github.com/kpagacz/tergo/tree/main/unguentum"
# See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html

[dependencies]
tokenizer = { package = "tergo-tokenizer", path = "../aqua", version = "0.2.3" }
tokenizer = { package = "tergo-tokenizer", path = "../aqua", version = "0.2.4" }
parser = { package = "tergo-parser", path = "../spongia", version = "0.2.4" }
log = "0.4.21"
serde = { version = "1.0.210", features = ["derive"] }
log = "0.4.25"
serde = { version = "1.0.217", features = ["derive"] }

[dev-dependencies]
env_logger = "0.11.3"
toml = "0.8.19"
simple_logger = { version = "5.0.0", default-features = false, features = [
"timestamps",
] }
toml = "0.8.20"
5 changes: 4 additions & 1 deletion unguentum/src/format.rs
Original file line number Diff line number Diff line change
Expand Up @@ -447,7 +447,10 @@ mod tests {
use super::*;

fn log_init() {
let _ = env_logger::builder().is_test(true).try_init();
match simple_logger::init_with_env() {
Ok(_) => {}
Err(err) => println!("Failed to initialize logger: {:?}", err),
}
}

#[test]
Expand Down
5 changes: 4 additions & 1 deletion unguentum/tests/config_parsing.rs
Original file line number Diff line number Diff line change
@@ -1,7 +1,10 @@
use tergo_formatter::config::{Config, FunctionLineBreaks};

fn log_init() {
let _ = env_logger::builder().is_test(true).try_init();
match simple_logger::init_with_env() {
Ok(_) => {}
Err(err) => println!("Error initializing logger: {:?}", err),
}
}

#[test]
Expand Down
Loading