VSC: Set up VSCE packaging pipeline (use 'make vscode_ext' in release)

.gitignore

@@ -2,5 +2,10 @@
 
 build/
 target/
+dist/
+*.vsix
 
 node_modules/
+
+# this file is generated on make because vsce requires a LICENSE file (misspelt), and is just a copy of LICENCE.
+integration/vscode-ext/LICENSE

Makefile

@@ -10,10 +10,11 @@ CARGO_TOML := $(SRC_DIR)/Cargo.toml
 
 NPM := npm
 NODE := node
+VSCE := vsce
 
-VSCODE_EXT_BUILD_DIR := $(BUILD_DIR)/integration/vscode-ext
 VSCODE_EXT_PREFIX := $(SRC_DIR)/integration/vscode-ext
-VSCODE_EXT_NPM_SCRIPT := build
+VSCODE_EXT_NPM_SCRIPT := build:dev
+VSCODE_EXT_DIST_DIR := $(VSCODE_EXT_PREFIX)/dist
 
 # this ensures `all` is run by default despite not being the first target in the Makefile
 .DEFAULT_GOAL := all
@@ -27,7 +28,6 @@ validate_cargo:
 		$(shell which $(CARGO)),\
 		$(info Cargo located at $(shell command -v $(CARGO))),\
 		$(error Cargo not found in PATH, but is required to build devinit))
-	@:
 
 validate_npm:
 	$(if \
@@ -38,13 +38,20 @@ validate_npm:
 		$(shell which $(NODE)),\
 		$(info Node.js located at $(shell command -v $(NODE))),\
 		$(error Node.js not found in PATH, but is required to build the devinit VS Code extension))
-	@:
+
+validate_vsce:
+	$(if \
+		$(shell which $(VSCE)),\
+		$(info vsce located at $(shell command -v $(VSCE))),\
+		$(error vsce not found in PATH, but is required to build the devinit VS Code extension))
 
 # run with DEBUG=1 to use debug configuration
 
 ifneq "$(DEBUG)" "1"
 CARGOFLAGS += --release
-VSCODE_EXT_NPM_SCRIPT = package
+VSCODE_EXT_NPM_SCRIPT = build:prod
+
+vscode_ext: | validate_vsce
 endif
 
 .PHONY: devinit vscode_ext
@@ -72,8 +79,18 @@ devinit: $(CARGO_TOML) | validate_cargo
 # Bundle the VS Code extension
 #
 
-vscode_ext: | validate_npm
-	JS_BUILD_DIR=$(VSCODE_EXT_BUILD_DIR) $(NPM) run --prefix=$(VSCODE_EXT_PREFIX) $(VSCODE_EXT_NPM_SCRIPT)
+$(VSCODE_EXT_PREFIX)/node_modules:
+	$(NPM) install --prefix=$(VSCODE_EXT_PREFIX)
+
+vscode_ext: | validate_npm $(VSCODE_EXT_PREFIX)/node_modules
+	$(NPM) run $(VSCODE_EXT_NPM_SCRIPT) --prefix=$(VSCODE_EXT_PREFIX)
+
+ifneq "$(DEBUG)" "1"
+	cp $(SRC_DIR)/LICENCE $(VSCODE_EXT_PREFIX)/LICENSE
+
+	cd $(VSCODE_EXT_PREFIX) && \
+	$(VSCE) package --out=$(VSCODE_EXT_DIST_DIR) --readme-path=$(SRC_DIR)/README.md
+endif
 
 
 #

integration/vscode-ext/.vscodeignore

@@ -0,0 +1,9 @@
+node_modules/
+src/
+
+**/*.map
+
+package-lock.json
+esbuild.mjs
+tsconfig.json
+.vscodeignore

integration/vscode-ext/esbuild.mjs

@@ -7,11 +7,9 @@
 
 import esbuild from "esbuild";
 
-const buildDir = process.env["JS_BUILD_DIR"];
+const buildDir = "dist";
 const isProd = process.env["NODE_ENV"] === "production";
 
-console.log(buildDir)
-
 const configBase = {
     bundle: true,
     minify: isProd,