Better command-not-found error reporting

Trying to fix problem where the user PATH environment variable isn't
being read when using Node's exec() function in the VSC extension.
That still happens, but at least the error when it does is a bit
more clear(!)

integration/vscode-ext/package.json

@@ -82,7 +82,9 @@
     "devDependencies": {
         "@types/node": "^20.12.12",
         "@types/vscode": "^1.88.0",
+        "@types/which": "^3.0.4",
         "esbuild": "^0.21.4",
-        "typescript": "^5.4.5"
+        "typescript": "^5.4.5",
+        "which": "^4.0.0"
     }
 }

integration/vscode-ext/src/runner.ts

@@ -7,6 +7,7 @@
 
 import * as child_process from "node:child_process";
 import * as util from "node:util";
+import which from "which";
 
 /**
  * Variants of devinit subcommands
@@ -35,9 +36,23 @@ export class Runner {
      * `then` is run after a succesful execution completes, otherwise `err` is run instead.
      * @returns The executed command as a verbatim string, for diagnostics
      */
-    public run(): Promise<{ stdout: string, stderr: string }> {
+    public async run(): Promise<{ stdout: string, stderr: string }> {
+        const path = (this.execPath !== "")
+            ? this.execPath
+            : await this.findDevinitPath();
+        if (!path) {
+            return Promise.reject(
+                "Couldn't find devinit installed on your machine. If you haven't already, download its latest release " +
+                "from GitHub: https://github.com/kosude/devinit/releases"
+            );
+        }
+
+        const cmd = `"${path}" ${this.buildArgs().join(" ")}`;
+
+        console.log(cmd);
+
         const exec = util.promisify(child_process.exec);
-        return exec(`"${this.execPath}" ${this.buildArgs().join(" ")}`);
+        return exec(cmd);
     }
 
     /**
@@ -80,6 +95,19 @@ export class Runner {
         return args;
     }
 
+    /**
+     * Look for the devinit installation on the system; undefined is returned if none could be found.
+     */
+    private async findDevinitPath(): Promise<string | undefined> {
+        // search PATH for devinit
+        const fromPath = await which("devinit", { nothrow: true });
+        if (fromPath) {
+            return fromPath;
+        }
+
+        return undefined;
+    }
+
     /**
      * Path to the `devinit` executable
      */

integration/vscode-ext/src/runnerState.ts

@@ -34,8 +34,7 @@ export class RunnerState {
      * This should be done when config changes (via listening to `vscode.workspace.onDidChangeConfiguration()`)
      */
     public updateUserConfigProperties() {
-        let execPath = userConfig.getExecutablePath();
-        this.execPath = (execPath.length > 0) ? execPath : "devinit";
+        this.execPath = userConfig.getExecutablePath();
 
         let configPath = userConfig.getConfigPath();
         this.configPath = (configPath.length > 0) ? configPath : undefined;

integration/vscode-ext/tsconfig.json

@@ -12,6 +12,7 @@
 		"noImplicitReturns": true,
 		"noFallthroughCasesInSwitch": true,
 		"noUnusedParameters": true,
-        "resolveJsonModule": true
+        "resolveJsonModule": true,
+        "esModuleInterop": true
 	}
 }