Greatly improve Java bf2 performance #175
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By doing some very simple changes to the existing Java implementation (using array instead of list, using final modifierers, avoiding Character/char autoboxing, reusing empty arrays) I can see a 100% performance improvement. This version apparently also runs significantly faster than version offered via #173
nuald
added a commit
to nuald/benchmarks
that referenced
this pull request
Oct 10, 2019
…ya#158, kostya#159, kostya#164, kostya#170, kostya#179). Removed Ruby Topaz and Rubinous as these are not the active projects anymore (the latter has some activity, but it neither can be properly compiled nor compatible with the used Ruby code). Fixed memory consumption calculation to include children processes (e.g. for Scala as it invokes the actual JVM process as a child). Minor tweaks to BF tests (normalizing data types and allocations if possible). Applied changes from PR kostya#157, kostya#167, kostya#177, kostya#175. Added relevant warming up for .NET projects (issue kostya#154), however it barely changed the results. Replaced D Mir GLAS (not supported anymore) with D lubeck (another linear algebra library also utilizing D Mir) test.
This was referenced Oct 10, 2019
Merged
|
Applied in another commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By doing some very simple changes to the existing Java implementation (using array instead of list, using final modifierers, avoiding Character/char autoboxing, reusing empty arrays) I can see a 100% performance improvement on my system using OpenJDK 8 and OpenJDK 11.
This version apparently also runs significantly faster than version offered via #173