Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/conllu dropped column should be an error #326

Merged
merged 8 commits into from
Nov 20, 2024

Conversation

MartinKl
Copy link
Collaborator

fixes #325

@MartinKl MartinKl enabled auto-merge November 20, 2024 15:15
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

Attention: Patch coverage is 89.47368% with 2 lines in your changes missing coverage. Please review.

Project coverage is 83.27%. Comparing base (fc6f77d) to head (27b3a48).

Files with missing lines Patch % Lines
src/importer/conllu/mod.rs 89.47% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #326      +/-   ##
==========================================
+ Coverage   83.24%   83.27%   +0.02%     
==========================================
  Files          54       54              
  Lines       19846    19836      -10     
  Branches    19846    19836      -10     
==========================================
- Hits        16521    16518       -3     
+ Misses       1199     1192       -7     
  Partials     2126     2126              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@MartinKl MartinKl merged commit 9404a04 into main Nov 20, 2024
11 checks passed
@MartinKl MartinKl deleted the fix/conllu-dropped-column-should-be-an-error branch November 20, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Import conllu: Leaving head id column goes unnoticed with severe consequences
1 participant