Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use a CorpusStorage to execute the AQL checks #195

Merged
merged 3 commits into from
Feb 19, 2024

Conversation

thomaskrause
Copy link
Member

No description provided.

@thomaskrause thomaskrause marked this pull request as ready for review February 19, 2024 12:52
Copy link

codecov bot commented Feb 19, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (8db6b0f) 81.50% compared to head (60e0489) 81.54%.

Files Patch % Lines
src/manipulator/check.rs 87.50% 0 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #195      +/-   ##
==========================================
+ Coverage   81.50%   81.54%   +0.03%     
==========================================
  Files          36       36              
  Lines       12115    12130      +15     
  Branches    12115    12130      +15     
==========================================
+ Hits         9874     9891      +17     
+ Misses        916      915       -1     
+ Partials     1325     1324       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@MartinKl MartinKl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works as expected

@MartinKl MartinKl merged commit 992fcfa into main Feb 19, 2024
10 checks passed
@MartinKl MartinKl deleted the feature/directly-query-aql branch February 19, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants