✨ Add bulk cancel functionality for analyses #769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: MiriSafra <[email protected]>
MiriSafra
changed the title
jortel
requested changes
Jan 6, 2025
jortel
reviewed
Jan 16, 2025
| // // @tags tasks | ||
| // // @success 202 | ||
| // // @router /tasks/{id}/cancel [put] | ||
| // // @param id path int true "Task ID" |
There was a problem hiding this comment.
Why were the additional // added? ^
jortel
reviewed
Jan 16, 2025
| // @description Cancel multiple tasks by IDs. | ||
| // @tags tasks | ||
| // @success 202 | ||
| // @router /tasks/cancel/list [put] |
There was a problem hiding this comment.
Semantically, I think it would be more correct for the PUT to be against the collection because the action is updating the collection. Ex: PUT /tasks/cancel (without the /list ). The collection implies multiple objects.
Better yet, PUT /tasks/cancel?filter=id:[1,2,3]. This would be the most RESTful and more powerful. For example, it would support selection of tasks to be canceled by task kind and state. Example: /tasks/cancel?filter=kind:discovery,state=Running. or all tasks for an application
/tasks/cancel?filter=application.id=44.
jortel
approved these changes
Jan 17, 2025
|
@MiriSafra Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a function for cancelling multiple analyses at once.
Part of: tackle2-ui issue #2153