Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFR] Questionnaire CRUD operations #769

Merged
merged 6 commits into from
Oct 26, 2023
Merged

[RFR] Questionnaire CRUD operations #769

merged 6 commits into from
Oct 26, 2023

Conversation

nachandr
Copy link
Contributor

@nachandr nachandr commented Oct 26, 2023 •
edited
Loading

  1. I will paste the results of the Jenkins run shortly .

@nachandr
Questionnaire CRUD operations
840ac05 
Signed-off-by: Nandini Chandra <[email protected]>
@nachandr
Questionnaire CRUD operations
8fc923a 
Signed-off-by: Nandini Chandra <[email protected]>
@nachandr nachandr changed the title [WIP] Questionnaire CRUD operations [RFR] Questionnaire CRUD operations Oct 26, 2023
ibragins
ibragins approved these changes Oct 26, 2023
View reviewed changes
Copy link
Collaborator

@ibragins ibragins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nachandr
Copy link
Contributor Author

Notes

  1. I'm looking to rename duplicateNameWarning and give it a more appropriate meaning since the same selector is being used in several places.

@nachandr
Updated selector name
91d2201 
Signed-off-by: Nandini Chandra <[email protected]>
@nachandr
Add questionnaire YAML file
73c80b5 
Signed-off-by: Nandini Chandra <[email protected]>
@nachandr
Add questionnaire
c43aed3 
Signed-off-by: Nandini Chandra <[email protected]>
@nachandr
A few updates
cc54139 
Signed-off-by: Nandini Chandra <[email protected]>
@nachandr
Copy link
Contributor Author

nachandr commented Oct 26, 2023 •
edited
Loading

Jenkins job for questionnaire CRUD

Results : All passed

questionnaire_crud_oct26

@nachandr
Copy link
Contributor Author

Migration wave field validation

Results : All passed

migration_wave_oct26

@sshveta sshveta merged commit 2924672 into konveyor:main Oct 26, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibragins ibragins ibragins approved these changes

@sshveta sshveta sshveta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nachandr @sshveta @ibragins