Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFR] Adding Prettier Plugin: Organize Imports #1312

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

mguetta1
Copy link
Contributor

Copy link
Collaborator

@kpunwatk kpunwatk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mguetta1 mguetta1 changed the title Adding Prettier Plugin: Organize Imports [RFR] Adding Prettier Plugin: Organize Imports Jan 21, 2025
Copy link
Collaborator

@abrugaro abrugaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some considerations here:

  1. How are you executing this? could you add it to the README?

  2. Can you please check if the package.json needs to be updated under the scripts property to ensure npm run check and npm run format also sort the imports?

  3. I'd like to wait until the next version is released and we cut a branch to merge this, I know it is just reordering imports, but there could be side effects and it will also make bugs harder to identify as you're going to be at the top of the history of modifications in git in almos all files.

@mguetta1
Copy link
Contributor Author

mguetta1 commented Jan 21, 2025

Some considerations here:

  1. How are you executing this? could you add it to the README?

npm run format takes care of that. Nothing special to document IMO

  1. Can you please check if the package.json needs to be updated under the scripts property to ensure npm run check and npm run format also sort the imports?

I tested it locally and looks like the needed changes are implemented. npm run check and npm run format work as expected

  1. I'd like to wait until the next version is released and we cut a branch to merge this, I know it is just reordering imports, but there could be side effects and it will also make bugs harder to identify as you're going to be at the top of the history of modifications in git in almos all files.

Sure thing. There is no rush to merge it. Thanks

@sshveta sshveta merged commit 3558a96 into konveyor:main Jan 21, 2025
8 of 9 checks passed
@mguetta1 mguetta1 deleted the organize-imports branch January 21, 2025 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants