Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Set up kai-eval in ci script #39

Merged
merged 3 commits into from
Dec 2, 2024
Merged

✨ Set up kai-eval in ci script #39

merged 3 commits into from
Dec 2, 2024

Conversation

abrugaro
Copy link
Collaborator

Part of #11 and #12, this PR includes:

  • The ability to execute run_demo.py (currently failing due to an error in the Kai release files)
  • The ability to fetch and execute kai-eval (currently using mock data placed in the fixtures folder due to the failure mentioned in the previous point)
  • The ability to generate the kai-eval report in JSON format and package everything into a zip file
  • Uploading the generated files to S3 (the Coolstore app with the code changes is missing due to the Kai failure)

@abrugaro
set up kai-eval
43a7591 
Signed-off-by: Alejandro Brugarolas <[email protected]>
@abrugaro abrugaro self-assigned this Nov 29, 2024
@abrugaro abrugaro requested a review from midays December 2, 2024 10:12
@abrugaro
fixes for windows
87b6c3f 
Signed-off-by: Alejandro Brugarolas <[email protected]>
midays
midays approved these changes Dec 2, 2024
View reviewed changes
Copy link
Collaborator

@midays midays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abrugaro
windows adaptations
ad9e1ea 
Signed-off-by: Alejandro Brugarolas <[email protected]>
@abrugaro abrugaro merged commit 898eba8 into konveyor:main Dec 2, 2024
2 checks passed
@abrugaro abrugaro deleted the set-up-kai-eval branch December 2, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@midays midays midays approved these changes

Assignees

@abrugaro abrugaro

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abrugaro @midays