Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👻 Update analyzerClient.ts #190

Merged
merged 3 commits into from
Jan 15, 2025
Merged

Conversation

JonahSussman
Copy link
Contributor

Update initialize parameters to align with konveyor/kai#526. Please feel free to commit to this PR.

Signed-off-by: Jonah Sussman <[email protected]>
@JonahSussman JonahSussman requested a review from a team as a code owner January 10, 2025 17:52
Copy link
Member

@djzager djzager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor changes...make the linter stop complaining.

vscode/src/client/analyzerClient.ts Show resolved Hide resolved
vscode/src/client/analyzerClient.ts Outdated Show resolved Hide resolved
vscode/src/client/analyzerClient.ts Outdated Show resolved Hide resolved
Signed-off-by: Jonah Sussman <[email protected]>
Signed-off-by: Jonah Sussman <[email protected]>
@sjd78
Copy link
Member

sjd78 commented Jan 15, 2025

This PR is superseded by #197

@sjd78 sjd78 dismissed djzager’s stale review January 15, 2025 17:27

Any additional changes will happen in #197

@sjd78 sjd78 merged commit 461e9ce into konveyor:main Jan 15, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants