🐛 Add back default config.toml values #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves: konveyor#160 Pending konveyor/kai#526, this change is needed so the kai-rpc-server starts. The initialize call should still override any model configurations in the toml file. Once the kai change to remove config.toml is merged, the TODOs added by this change will need to be resolved. Signed-off-by: Scott J Dickerson <[email protected]>
|
You can just add the values into the settings.json for providerArgs and provider name to fix this. No need to add to the config.toml defaults. |
djzager
approved these changes
Dec 16, 2024
|
Confirmed this is an issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #160
Pending konveyor/kai#526, this change is needed so the kai-rpc-server starts. The initialize call should still override any model configurations in the toml file.
Once the kai change to remove
config.tomlis merged, the TODOs added by this change will need to be resolved.