Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature/NiFiCluster] Add services and pods labels #23

Merged
merged 4 commits into from
Mar 17, 2022

Conversation

juldrixx
Copy link
Contributor

@juldrixx juldrixx commented Mar 16, 2022

Q A
Bug fix? yes
New feature? yes
API breaks? yes
Deprecations? no
Related tickets Orange-OpenSource/nifikop#150
License Apache 2.0

What's in this PR?

Ability to attach arbitrary labels to pods and services that nifikop creates.

Why?

Can be useful to select pods for log aggregation via https://rancher.com/docs/rancher/v2.6/en/logging/

Checklist

  • Implementation tested
  • Error handling code meets the guideline
  • Logging code meets the guideline
  • User guide and development docs updated (if needed)
  • Append changelog with changes

@juldrixx juldrixx requested a review from erdrix March 16, 2022 21:38
@erdrix erdrix merged commit e0e9ad4 into master Mar 17, 2022
@erdrix erdrix deleted the feature/add-pod-and-service-labels branch March 17, 2022 08:01
erdrix pushed a commit that referenced this pull request Aug 3, 2022
* Add services and pods labels

* Update docs

* Update changelog

* Update samples
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants