Worflow: refactoring SPR to standard cmake and suppress warnings #2502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucbv
added
AT2-SPECIAL-APPROVAL
|
Do we want to add |
jgfouca
approved these changes
Feb 19, 2025
|
@lucbv I think it's worth trying the suppression with the linker flags to see if it quiets down the noise in the output |
The -Wpass-fail warnings are poluting the output of the compiler this does not really tell us anything either so let us suppress these. Addtionally, suppressing linker warnging with -Wno-unused-command-line-argument. The build comes out a lot cleaner now. Signed-off-by: Luc Berger-Vergiat <[email protected]>
lucbv
force-pushed
the
spr_workflow_refactor
branch
from
246af63 to
27cfaab
Compare
lucbv
added
AT2-SPECIAL-APPROVAL
|
This latest update suppresses the linker warning we use to have, it looks like it's mostly building warning free now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The -Wpass-fail warnings are poluting the output of the compiler this does not really tell us anything either so let us suppress these.