Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add volta70 AT2 checks #2325

Closed
wants to merge 11 commits into from
Closed

Add volta70 AT2 checks #2325

wants to merge 11 commits into from

Conversation

e10harvey
Copy link
Contributor

No description provided.

@kokkos-devops-admin kokkos-devops-admin added the AT2-SPECIAL-APPROVAL Mark .github changes as approved. label Sep 3, 2024
@kokkos-devops-admin kokkos-devops-admin added AT2-SPECIAL-APPROVAL Mark .github changes as approved. and removed AT2-SPECIAL-APPROVAL Mark .github changes as approved. labels Sep 3, 2024
@kokkos-devops-admin kokkos-devops-admin added AT2-SPECIAL-APPROVAL Mark .github changes as approved. and removed AT2-SPECIAL-APPROVAL Mark .github changes as approved. labels Sep 3, 2024
@kokkos-devops-admin kokkos-devops-admin added AT2-SPECIAL-APPROVAL Mark .github changes as approved. and removed AT2-SPECIAL-APPROVAL Mark .github changes as approved. labels Sep 3, 2024
@kokkos-devops-admin kokkos-devops-admin added AT2-SPECIAL-APPROVAL Mark .github changes as approved. and removed AT2-SPECIAL-APPROVAL Mark .github changes as approved. labels Sep 4, 2024
@kokkos-devops-admin kokkos-devops-admin added AT2-SPECIAL-APPROVAL Mark .github changes as approved. and removed AT2-SPECIAL-APPROVAL Mark .github changes as approved. labels Sep 4, 2024
lucbv
lucbv approved these changes Sep 6, 2024
View reviewed changes
Copy link
Contributor

@lucbv lucbv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable although one thing that would be good is to use the latest release of Kokkos Core, 4.4.00 at this time, as we do with the current auto-tester. I believe changing from ref: ${{ github.base_ref} to the 4.4.0 tag might be the way to handle that

@lucbv
Copy link
Contributor

lucbv commented Sep 6, 2024

Also should we actually run the volta 70 jobs to check that they run and pass before merging?

@kokkos-devops-admin kokkos-devops-admin added AT2-SPECIAL-APPROVAL Mark .github changes as approved. and removed AT2-SPECIAL-APPROVAL Mark .github changes as approved. labels Sep 11, 2024
@e10harvey
Copy link
Contributor Author

Also should we actually run the volta 70 jobs to check that they run and pass before merging?

Yea, the CLANG13CUDA check does fail a few tests with #2005.

@kokkos-devops-admin kokkos-devops-admin added AT2-SPECIAL-APPROVAL Mark .github changes as approved. and removed AT2-SPECIAL-APPROVAL Mark .github changes as approved. labels Sep 17, 2024
@kokkos-devops-admin kokkos-devops-admin added AT2-SPECIAL-APPROVAL Mark .github changes as approved. and removed AT2-SPECIAL-APPROVAL Mark .github changes as approved. labels Sep 17, 2024
@e10harvey
Copy link
Contributor Author

@ndellingwood, @lucbv: I'd like to get this PR merged, do you know the ctest regex syntax that's needed to exclude the failing tests? e.g., see 8d9a0eb

@kokkos-devops-admin kokkos-devops-admin added AT2-SPECIAL-APPROVAL Mark .github changes as approved. and removed AT2-SPECIAL-APPROVAL Mark .github changes as approved. labels Sep 18, 2024
@kokkos-devops-admin kokkos-devops-admin added AT2-SPECIAL-APPROVAL Mark .github changes as approved. and removed AT2-SPECIAL-APPROVAL Mark .github changes as approved. labels Sep 18, 2024
@lucbv
Copy link
Contributor

lucbv commented Oct 2, 2024

@e10harvey after merging the BDW PR this now needs a rebase, should be easy. Once you have it done I'll have a final look.

@lucbv
Copy link
Contributor

lucbv commented Oct 3, 2024

PR #2356 now supersedes this

@lucbv lucbv closed this Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucbv lucbv lucbv approved these changes

Assignees
No one assigned
Labels
AT: WIP AT2-SPECIAL-APPROVAL Mark .github changes as approved.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@e10harvey @lucbv @kokkos-devops-admin