Sparse - StaticCrsGraph: fixing issues with perf tests and docs

A few performance tests had not been updated to use the new namespace for the graph overload of create_mirror. Additionally some of the inline documentation for StaticCrsGraph is wrong... Signed-off-by: Luc Berger-Vergiat <[email protected]>
kokkos · Dec 10, 2024 · d9e7f47 · d9e7f47
1 parent b8efaef
commit d9e7f47
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 6 deletions.
diff --git a/perf_test/sparse/KokkosSparse_spmv_struct.cpp b/perf_test/sparse/KokkosSparse_spmv_struct.cpp
@@ -244,7 +244,7 @@ int main(int argc, char **argv) {
 
     if (check_errors) {
       h_y_compare                                                  = Kokkos::create_mirror(y);
-      typename matrix_type::StaticCrsGraphType::HostMirror h_graph = Kokkos::create_mirror(A.graph);
+      typename matrix_type::StaticCrsGraphType::HostMirror h_graph = KokkosSparse::create_mirror(A.graph);
       typename matrix_type::values_type::HostMirror h_values       = Kokkos::create_mirror_view(A.values);
 
       // Error Check Gold Values

diff --git a/perf_test/sparse/KokkosSparse_spmv_struct_tuning.cpp b/perf_test/sparse/KokkosSparse_spmv_struct_tuning.cpp
@@ -395,7 +395,7 @@ int main(int argc, char** argv) {
 
     if (check_errors) {
       h_y_compare                                                  = Kokkos::create_mirror(y);
-      typename matrix_type::StaticCrsGraphType::HostMirror h_graph = Kokkos::create_mirror(A.graph);
+      typename matrix_type::StaticCrsGraphType::HostMirror h_graph = KokkosSparse::create_mirror(A.graph);
       typename matrix_type::values_type::HostMirror h_values       = Kokkos::create_mirror_view(A.values);
 
       // Error Check Gold Values

diff --git a/perf_test/sparse/KokkosSparse_spmv_test.cpp b/perf_test/sparse/KokkosSparse_spmv_test.cpp
@@ -64,7 +64,7 @@ SPMVTestData setup_test(spmv_additional_data* data, SPMVTestData::matrix_type A,
   test_data.h_y         = Kokkos::create_mirror_view(y);
   test_data.h_y_compare = Kokkos::create_mirror(y);
 
-  h_graph_type h_graph   = Kokkos::create_mirror(test_data.A.graph);
+  h_graph_type h_graph   = KokkosSparse::create_mirror(test_data.A.graph);
   h_values_type h_values = Kokkos::create_mirror_view(test_data.A.values);
 
   for (int i = 0; i < test_data.numCols; i++) {

diff --git a/sparse/src/KokkosSparse_StaticCrsGraph.hpp b/sparse/src/KokkosSparse_StaticCrsGraph.hpp
@@ -162,8 +162,7 @@ struct GraphRowViewConst {
  public:
   /// \brief Constructor
   ///
-  /// \param values [in] Array of the row's values.
-  /// \param colidx [in] Array of the row's column indices.
+  /// \param colidx_in [in] Array of the row's column indices.
   /// \param stride [in] (Constant) stride between matrix entries in
   ///   each of the above arrays.
   /// \param count [in] Number of entries in the row.
@@ -173,7 +172,7 @@ struct GraphRowViewConst {
 
   /// \brief Constructor with offset into \c colidx array
   ///
-  /// \param colidx [in] Array of the row's column indices.
+  /// \param colidx_in [in] Array of the row's column indices.
   /// \param stride [in] (Constant) stride between matrix entries in
   ///   each of the above arrays.
   /// \param count [in] Number of entries in the row.