Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix button maps #17

Merged
merged 1 commit into from
Dec 9, 2023
Merged

Fix button maps #17

merged 1 commit into from
Dec 9, 2023

Conversation

KOPRajs
Copy link
Contributor

@KOPRajs KOPRajs commented Dec 8, 2023

Add the missing START button and fix the button order and some white spaces along the way. The order of buttons is now in sync with the controller layout.xml.

I was unable to start Mario 64 because of the "Press START button" in the beginning.

@garbear
Copy link
Member

garbear commented Dec 9, 2023

Start button should clearly be there so this looks good to me. Does mupen64plus-nx actually work in kodi, given that it requires opengl?

@garbear garbear merged commit 776f8a6 into kodi-game:master Dec 9, 2023
@KOPRajs
Copy link
Contributor Author

KOPRajs commented Dec 9, 2023

Start button should clearly be there so this looks good to me. Does mupen64plus-nx actually work in kodi, given that it requires opengl?

Yes, it does, because there is a software renderer available which doesn't need the OpenGL. I've used a build for x86 from here:
https://github.com/jefflessard/game.retroarch

You need to go to the add-on settings first and change the renderer from GlideN64 to Angrylion.

@garbear
Copy link
Member

garbear commented Dec 9, 2023

I assume they'll pick your buttonmap? https://github.com/jefflessard/game.retroarch/blob/main/game.libretro.mupen64plus-nx/resources/buttonmap.xml is still missing start.

We can simply patch this core to default to software rendering so that you don't need to open config before launching it.

@garbear
Copy link
Member

garbear commented Dec 9, 2023

Patching the core to use Angrylion by default would fix kodi-game/game.libretro#83.

@KOPRajs
Copy link
Contributor Author

KOPRajs commented Dec 10, 2023

I assume they'll pick your buttonmap? https://github.com/jefflessard/game.retroarch/blob/main/game.libretro.mupen64plus-nx/resources/buttonmap.xml is still missing start.

That's how I've found out that the START is missing. I expect they've used this repo as an upstream source for the add-on files, so they can update it when it is merged.

Regarding the kodi-game/game.libretro#83.
If I get it right, he suggests adding another patched renderer called Angrylion RDP Plus to the core (for even better performance). I would leave this work for the upstream https://github.com/libretro/mupen64plus-libretro-nx. I'm not sure why this forked renderer was not merged back to the upstream libretro core, but that seems to be beyond the Retroplayer's scope. I'd rather see Retroplayer getting the GL context support which would get us a fully working N64 on other platforms as well.

I haven't checked if this add-on built for Windows works with the render set to Angrylion as well. If it does, we might temporarily set the Angrylion as default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants