Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(exoflex): simple tab component without lazy load #376

Open
wants to merge 26 commits into
base: master
Choose a base branch
from
Open

feat(exoflex): simple tab component without lazy load #376

wants to merge 26 commits into from

Conversation

oshimayoan
Copy link
Contributor

@oshimayoan oshimayoan commented Mar 6, 2020 •
edited
Loading

Will resolve #171.

For this PR there fill be no lazy load feature yet but it will be added on another PR.

TODO:

  • Tab Bar
  • Tab Bar Indicator
  • Tab Bar Animation
  • Custom Tab Bar styling
  • Custom Tab Bar Indicator styling
  • Custom Tab Bar Animation
  • Tab Content (No Lazy Load)
  • Tab Content (Lazy Load)
  • Change Tab Content using Tab Bar
  • Change Tab Content using Swipe
  • Prop to toggle Tab swipe
  • Prop to toggle Lazy Load
  • Web Accessibility
  • Native Accessibility
  • Tests

@oshimayoan oshimayoan added the wip Work in progress label Mar 6, 2020
@oshimayoan oshimayoan changed the title feat(exoflex): tab component feat(exoflex): simple tab component without lazy load Mar 6, 2020
@oshimayoan oshimayoan marked this pull request as ready for review March 9, 2020 10:07
@oshimayoan oshimayoan added ready for review and removed wip Work in progress labels Mar 9, 2020
oshimayoan added 25 commits March 17, 2020 10:22
@oshimayoan
feat(exoflex): simplest tab component
5e834b1
@oshimayoan
build(exoflex): install react-native-reanimated
b15a5a8
@oshimayoan
feat(exoflex): supports tab indicator animation for native only
fbf8b37
@oshimayoan
refactor(exoflex): change TabView props implementation
827fe80
@oshimayoan
feat(exoflex): show scene with no lazy load and change scene using tab
fa122b2
@oshimayoan
feat(exoflex): custom hooks for Tab
e7c3fc8
@oshimayoan
feat(exoflex): change tab content using swipe
9eab84b
@oshimayoan
feat(exoflex): lazyload tab
6a34a65
@oshimayoan
fix(exoflex): tab content styling fix
1c38392
@oshimayoan
fix(exoflex): change changeTabIndex to jumpTo
bd6ed0b
@oshimayoan
feat(exoflex): prop to toggle swipe functionality
f42034e
@oshimayoan
feat(exoflex): custom tab bar styling
458bfef
@oshimayoan
feat(exoflex): custom tab indicator styling
5fd6cfd
@oshimayoan
fix(exoflex): rename useTabSwipe to useTab
cb82538
@oshimayoan
fix(exoflex): disable swipe feature on web
efb2a80
@oshimayoan
fix(exoflex): remove unused prop from TabBarItem
d87e2b6
@oshimayoan
feat(exoflex): web and native accessibility
cedf836
@oshimayoan
fix(exoflex): styling on web
8a2e6bd
@oshimayoan
refactor(exoflex): rewrite tab content using gesture and reanimated
5b88213 
refactor(exoflex): rewrite tab content using gesture and reanimated
@oshimayoan
fix(exoflex): move TabContent logic to useTab hooks
f409610
@oshimayoan
test(exoflexx): mock RNGH and react-native-reanimated
72486d7
@oshimayoan
test(exoflex): tabview without lazy load
9de6e2a
@oshimayoan
chore(exoflex): uninstall react-native-tab-view
af8969f
@oshimayoan
chore(exoflex): tab view example
14de536
@oshimayoan
fix(exofle): fix web
49df71e
@oshimayoan
Copy link
Contributor Author

Hey @kodefox/infra, what do you think of this approach? If you guys like it, we could continue to build lazy load support but if not, we could just close this and use react-native-tab-view instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

exoflex: tab
1 participant
@oshimayoan