Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exoflex: tab #171

Open
gataandri opened this issue Oct 31, 2019 · 6 comments · May be fixed by #376
Open

exoflex: tab #171

gataandri opened this issue Oct 31, 2019 · 6 comments · May be fixed by #376
Assignees
Labels
enhancement New feature or request

Comments

@gataandri
Copy link

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

I would like to request tab for Oasis. This is the design we have in Oasis.
Screen_Shot_2019-10-25_at_2 09 26_PM

You could access the full designs via this link
https://app.zeplin.io/project/5d7f328dd8a94c18ede239ee

Describe the solution you'd like
A clear and concise description of what you want to happen.
@ajilantang do you have description how this feature would like to be?

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@gataandri gataandri added the enhancement New feature or request label Oct 31, 2019
@aria6 aria6 assigned aria6 and unassigned aria6 Nov 5, 2019
@aria6
Copy link

aria6 commented Nov 5, 2019

Hii @gataandri @ajilantang
What do you need in this tab? I think it just will receive label and scene right? If yes I will make it for you two.

Oh ya for @kodefox/infra team, should we use the library for this Tab? Or we can make own self?
We have react-native-tab-view for library

@oshimayoan
Copy link
Contributor

We haven't really discussed this yet. But I think this is a good start.

I'm not sure about using react-native-tab-view for this right now. Because there is an issue with the web support currently.

It was working fine before (satya164/react-native-tab-view#159) but it seems there is something that it broke on the web (satya164/react-native-tab-view#896).

@ajilantang
Copy link

yaps dian, I need this to run on the web, android, and ios. I hope on the web we can swipe like mobile.If you want to see this Issue if you are using react-native-tab-view

@oshimayoan
Copy link
Contributor

oshimayoan commented Nov 5, 2019

Also, I think we have design for Tab.
image

But need to discuss how much customization is acceptable.

@ajilantang
Copy link

or maybe we can use this react swipeable it's running well on three platforms.

@sstur
Copy link
Member

sstur commented Nov 6, 2019

Looking at this now, I think react swipeable seems like a great idea. They have a tabs demo on their site and it seems to support the kind of gestures and animations we need.

I worked with Aji on the implementation for Oasis and we used react-native-tab-view for mobile and a custom implementation for web with just a subset of features, no swiping. (actually I don't care much about swiping tabs, maybe because I'm an iOS user and we use swipe for a different purpose; for list items).

@oshimayoan oshimayoan modified the milestone: exoflex v3.2.0 Feb 6, 2020
@oshimayoan oshimayoan added this to the exoflex v3.2.0 milestone Feb 6, 2020
@oshimayoan oshimayoan self-assigned this Feb 13, 2020
@oshimayoan oshimayoan linked a pull request Mar 6, 2020 that will close this issue
15 tasks
@oshimayoan oshimayoan modified the milestones: exoflex v3.3.0, exoflex v3.4.0 Mar 30, 2020
@oshimayoan oshimayoan removed this from the exoflex v3.4.0 milestone May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
5 participants