fix: ids too large #11315
Merged
fix: ids too large #11315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying koda-art-prod with
|
| Latest commit: |
c2c0714
|
| Status: | ⚡️ Build in progress... |
❌ Deploy Preview for koda-canary failed. Why did it fail? →
|
✅ Deploy Preview for polkadot ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
preschian
requested review from
vikiival,
Jarsen136 and
hassnian
and removed request for
a team
hassnian
reviewed
Jan 1, 2025
hassnian
reviewed
Jan 1, 2025
…service to use it
…fer and improve ID generation logic in dyndata service
|
Hi team @kodadot/internal-dev, if there are no concerns, I recommend deploying this PR as a hotfix to production to support backward compatibility of IDs with older drops on AssethHub I will write a postmortem for more details regarding this issue |
hassnian
approved these changes
Jan 4, 2025
Jarsen136
approved these changes
Jan 6, 2025
|
|
merging this one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution to the Koda - Generative Art Marketplace.
👇 __ Let's make a quick check before the contribution.
PR Type
Context
nextIdu32 input too large #11314. fix ids too large on assethub: