Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[app] Add Integrations for Kubernetes Resources #401

Merged
merged 1 commit into from
Jul 22, 2022

Conversation

ricoberger
Copy link
Member

Add a new integrations feature for kobs. In this first iteration we
implemented the suggested integrations feature from #255 for Kubernetes
Resources.

This integration allows an administrator of kobs to add a set of default
dashboards to Kubernetes Resources. This way we can add for example a
resource usage dashboard to all Pods, without that each Pod must have
the "kobs.io/dashboards" annotation.

The configured dashboards in the integrations and the dashboards from
the "kobs.io/dashboards" annotation are always merged and not
overwritte.

Add a new integrations feature for kobs. In this first iteration we
implemented the suggested integrations feature from #255 for Kubernetes
Resources.

This integration allows an administrator of kobs to add a set of default
dashboards to Kubernetes Resources. This way we can add for example a
resource usage dashboard to all Pods, without that each Pod must have
the "kobs.io/dashboards" annotation.

The configured dashboards in the integrations and the dashboards from
the "kobs.io/dashboards" annotation are always merged and not
overwritte.
@codecov-commenter
Copy link

Codecov Report

Merging #401 (13b86b8) into main (4490c9f) will decrease coverage by 0.04%.
The diff coverage is 16.66%.

@@            Coverage Diff             @@
##             main     #401      +/-   ##
==========================================
- Coverage   45.70%   45.66%   -0.05%     
==========================================
  Files         137      137              
  Lines       10661    10672      +11     
==========================================
  Hits         4873     4873              
- Misses       5695     5706      +11     
  Partials       93       93              
Impacted Files Coverage Δ
pkg/hub/api/plugins/plugins.go 0.00% <0.00%> (ø)
pkg/hub/api/resources/resources.go 0.00% <0.00%> (ø)
pkg/hub/hub.go 0.00% <0.00%> (ø)
pkg/hub/api/applications/applications.go 100.00% <100.00%> (ø)
pkg/hub/api/clusters/clusters.go 100.00% <100.00%> (ø)
pkg/hub/api/dashboards/dashboards.go 100.00% <100.00%> (ø)
pkg/hub/api/teams/teams.go 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us.

@ricoberger ricoberger merged commit 4c27350 into main Jul 22, 2022
@ricoberger ricoberger deleted the app-add-integrations-for-kubernetes-resources branch July 22, 2022 19:22
@ricoberger ricoberger linked an issue Jul 22, 2022 that may be closed by this pull request
@ricoberger ricoberger added the changelog: added A new feature was added label Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: added A new feature was added
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[core] Add Integrations
2 participants