Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow blade syntax in baseUrl config #944

Open
wants to merge 1 commit into
base: v4
Choose a base branch
from

Conversation

chengkangzai
Copy link

@chengkangzai chengkangzai commented Feb 8, 2025

Fixes #943

This PR allows the use of Blade syntax in the baseUrl configuration by rendering the value through the Blade facade before displaying it.

Changes

  • Added Blade facade import
  • Wrapped baseUrl values in Blade::render() to process any Blade syntax

Notes

  • Tested with Laravel only, compatibility with Dingo API has not been verified
  • This enables dynamic baseUrl values using Blade syntax like {{ config('app.url') }} or {{ config('app.tenant_url') }}

References

Let me know if any changes are needed!

…namic content in variables and improve URL display
@chengkangzai chengkangzai changed the title Use Blade templating engine for rendering namic content in variables and improve URL display fix: allow blade syntax in baseUrl config Feb 8, 2025
@shalvah
Copy link
Contributor

shalvah commented Feb 18, 2025

Can you change this to do the render call before pasing it to the view? That way, it works for all themese, not just elements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dynamic String not escape properly when using elements theme
2 participants