Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: parameter handling and type errors in Output classes #937

Closed

Conversation

goktugoner23
Copy link

Fix Parameter Handling and Type Errors

Description

This PR fixes several issues related to parameter handling in the Output classes:

  1. Fixed memory exhaustion caused by infinite recursion in Parameter class inheritance
  2. Fixed type errors with nullable parameters
  3. Improved parameter conversion between Extraction and Output namespaces

Changes

  • Modified Output/Parameter.php to:

    • Change inheritance from Extraction Parameter to BaseDTO
    • Add proper property initialization
    • Handle conversion from Extraction Parameter properly
    • Fix nullable parameter handling
  • Modified Output/OutputEndpointData.php to:

    • Fix parameter conversion in constructor
    • Handle metadata properly
    • Prevent infinite recursion in nested parameters

Testing

All existing tests pass, including:

  • Parameter nesting tests
  • Output endpoint data tests
  • Extractor tests

Related Issues

Fixes #[issue_number] - Memory exhaustion in parameter handling
Fixes #[issue_number] - Type errors with nullable parameters

Backwards Compatibility

These changes maintain full backwards compatibility with existing API and functionality.

@goktugoner23 goktugoner23 closed this by deleting the head repository Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant