Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ending_at to Schedule #85

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

devin-ai-integration[bot]
Copy link
Contributor

This PR adds an optional ending_at property to the Schedule interfaces in the knock-node SDK.

Changes

  • Added ending_at?: string | null to the Schedule interface
  • Added ending_at?: string to CreateSchedulesProps interface (which is also inherited by UpdateSchedulesProps)

Implementation Details

  • The property is optional and requires no validation in the SDK
  • Format follows the same pattern as other date fields (ISO-8601 string)
  • No breaking changes to existing functionality

Testing

  • Existing tests continue to pass
  • No additional tests were needed as the property is optional and follows the same pattern as other date fields

Link to Devin run

https://app.devin.ai/sessions/78a792caa098421fb3045c0423cd7d56

Copy link
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add "(aside)" to your comment to have me ignore it.
  • Look at CI failures and help fix them

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@cjbell cjbell merged commit 46a3126 into main Jan 28, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant